You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems to be problematic to not use official react-redux connector.
The custom implementation we are currently using doesn't care about state modification notification order. This means that a child component can be notified of a state modification (a route change) before the HOC it self, leading to an inconsistent render of the child (it shouldn't be rendered if the route is not matched).
This can perhaps be avoid by using the react-redux connector. It handles the order of notification (it's one of the main problem solved by this library). So it should resolve or inconsistent rendering problem. And clean up our code base of not redux-litle-router related specific code.
I will try to make a PR to fix that soon.
The text was updated successfully, but these errors were encountered:
It seems to be problematic to not use official
react-redux
connector.The custom implementation we are currently using doesn't care about state modification notification order. This means that a child component can be notified of a state modification (a route change) before the HOC it self, leading to an inconsistent render of the child (it shouldn't be rendered if the route is not matched).
This can perhaps be avoid by using the
react-redux
connector. It handles the order of notification (it's one of the main problem solved by this library). So it should resolve or inconsistent rendering problem. And clean up our code base of notredux-litle-router
related specific code.I will try to make a PR to fix that soon.
The text was updated successfully, but these errors were encountered: