Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-redux connector #42

Open
EmrysMyrddin opened this issue Oct 17, 2018 · 0 comments
Open

Use react-redux connector #42

EmrysMyrddin opened this issue Oct 17, 2018 · 0 comments

Comments

@EmrysMyrddin
Copy link
Collaborator

It seems to be problematic to not use official react-redux connector.

The custom implementation we are currently using doesn't care about state modification notification order. This means that a child component can be notified of a state modification (a route change) before the HOC it self, leading to an inconsistent render of the child (it shouldn't be rendered if the route is not matched).

This can perhaps be avoid by using the react-redux connector. It handles the order of notification (it's one of the main problem solved by this library). So it should resolve or inconsistent rendering problem. And clean up our code base of not redux-litle-router related specific code.

I will try to make a PR to fix that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant