feat(platform): add OS name and default shell retrieval for multiple platforms #453

Author: phodal

mpp-core/src/androidMain/kotlin/cc/unitmesh/agent/Platform.kt

@@ -6,5 +6,13 @@ actual object Platform {
     actual val isJs: Boolean = false
     actual val isWasm: Boolean = false
     actual val isAndroid: Boolean = true
+
+    actual fun getOSName(): String {
+        return "Android ${android.os.Build.VERSION.RELEASE}"
+    }
+
+    actual fun getDefaultShell(): String {
+        return "sh"  // Android uses sh shell
+    }
 }
 

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/CodingAgent.kt

@@ -10,6 +10,7 @@ import cc.unitmesh.agent.subagent.ErrorRecoveryAgent
 import cc.unitmesh.agent.subagent.LogSummaryAgent
 import cc.unitmesh.agent.subagent.CodebaseInvestigatorAgent
 import cc.unitmesh.agent.tool.ToolResult
+import cc.unitmesh.agent.tool.ToolNames
 import cc.unitmesh.agent.tool.registry.ToolRegistry
 import cc.unitmesh.agent.tool.filesystem.DefaultToolFileSystem
 import cc.unitmesh.agent.tool.shell.DefaultShellExecutor
@@ -57,7 +58,7 @@ class CodingAgent(
         displayName = "Autonomous Coding Agent",
         description = "Autonomous coding agent for development tasks",
         promptConfig = PromptConfig(
-            systemPrompt = buildCodingAgentSystemPrompt(),
+            systemPrompt = "You are an autonomous coding agent. Use the available tools to complete development tasks.",
             queryTemplate = "Task: \${requirement}\nProject Path: \${projectPath}",
             initialMessages = emptyList()
         ),
@@ -73,7 +74,15 @@ class CodingAgent(
             terminateOnError = false
         ),
         toolConfig = ToolConfig(
-            allowedTools = listOf("read-file", "write-file", "shell", "glob", "error-recovery", "log-summary", "codebase-investigator")
+            allowedTools = listOf(
+                ToolNames.READ_FILE,
+                ToolNames.WRITE_FILE,
+                ToolNames.SHELL,
+                ToolNames.GLOB,
+                ToolNames.ERROR_RECOVERY,
+                ToolNames.LOG_SUMMARY,
+                ToolNames.CODEBASE_INVESTIGATOR
+            )
         )
     )
 ), CodingAgentService {
@@ -179,7 +188,6 @@ class CodingAgent(
             )
         )
 
-        // 使用 DefaultAgentExecutor 执行
         val result = agentExecutor.execute(
             definition = definition,
             context = context,
@@ -248,57 +256,10 @@ class CodingAgent(
         }
     }
 
-    /**
-     * Build system prompt for CodingAgent
-     */
-    private fun buildCodingAgentSystemPrompt(): String {
-        return """
-You are an autonomous coding agent specialized in software development tasks.
-
-## Your Capabilities
-- Analyze project structure and understand codebases
-- Read and write files
-- Execute shell commands
-- Generate and modify code
-- Run tests and fix errors
-- Use SubAgents for specialized tasks (error recovery, log analysis, codebase investigation)
-
-## Available Tools
-- read-file: Read file contents
-- write-file: Create or modify files
-- shell: Execute shell commands
-- glob: Search for files using patterns
-- error-recovery: Analyze and recover from errors (SubAgent)
-- log-summary: Summarize long command outputs (SubAgent)
-- codebase-investigator: Analyze codebase structure and investigate code patterns (SubAgent)
-
-## Working Process
-1. Understand the task requirements
-2. Analyze the project structure
-3. Plan your approach
-4. Execute actions step by step
-5. Test and verify your changes
-6. Use error recovery when commands fail
-7. Call complete_task when finished
-
-## Important Rules
-- Always use DevIns format for tool calls: <devin>/tool-name param="value"</devin>
-- Read files before modifying them to understand the context
-- Test your changes after making them
-- Use error-recovery SubAgent when shell commands fail
-- Call complete_task tool when the task is finished
-- Be methodical and explain your reasoning
-
-## Output Format
-- Explain your thinking process
-- Use tool calls to perform actions
-- Provide clear status updates
-- Call complete_task with a summary when done
-        """.trimIndent()
-    }
-
     override fun buildSystemPrompt(context: CodingAgentContext, language: String): String {
-        return buildCodingAgentSystemPrompt()
+        val renderer = CodingAgentPromptRenderer()
+        val tools = getAllTools()
+        return renderer.renderSystemPrompt(tools, language)
     }
 
     override suspend fun initializeWorkspace(projectPath: String) {
@@ -319,51 +280,3 @@ You are an autonomous coding agent specialized in software development tasks.
     }
 }
 
-/**
- * Build system prompt for CodingAgent
- */
-private fun buildCodingAgentSystemPrompt(): String {
-    return """
-You are an autonomous coding agent specialized in software development tasks.
-
-## Your Capabilities
-- Analyze project structure and understand codebases
-- Read and write files
-- Execute shell commands
-- Generate and modify code
-- Run tests and fix errors
-- Use SubAgents for specialized tasks (error recovery, log analysis, codebase investigation)
-
-## Available Tools
-- read-file: Read file contents
-- write-file: Create or modify files
-- shell: Execute shell commands
-- glob: Search for files using patterns
-- error-recovery: Analyze and recover from errors (SubAgent)
-- log-summary: Summarize long command outputs (SubAgent)
-- codebase-investigator: Analyze codebase structure and investigate code patterns (SubAgent)
-
-## Working Process
-1. Understand the task requirements
-2. Analyze the project structure
-3. Plan your approach
-4. Execute actions step by step
-5. Test and verify your changes
-6. Use error recovery when commands fail
-7. Call complete_task when finished
-
-## Important Rules
-- Always use DevIns format for tool calls: <devin>/tool-name param="value"</devin>
-- Read files before modifying them to understand the context
-- Test your changes after making them
-- Use error-recovery SubAgent when shell commands fail
-- Call complete_task tool when the task is finished
-- Be methodical and explain your reasoning
-
-## Output Format
-- Explain your thinking process
-- Use tool calls to perform actions
-- Provide clear status updates
-- Call complete_task with a summary when done
-    """.trimIndent()
-}

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/CodingAgentPromptRenderer.kt

@@ -1,6 +1,12 @@
 package cc.unitmesh.agent
 
+import cc.unitmesh.agent.tool.Tool
+import cc.unitmesh.agent.Platform
 import cc.unitmesh.devins.compiler.template.TemplateCompiler
+import cc.unitmesh.devins.compiler.variable.VariableTable
+import cc.unitmesh.devins.compiler.variable.VariableType
+import cc.unitmesh.devins.compiler.variable.VariableScope
+import kotlinx.datetime.Clock
 
 /**
  * Renders system prompts for the coding agent using templates and context
@@ -12,7 +18,7 @@ class CodingAgentPromptRenderer {
 
     /**
      * Render system prompt from context
-     * 
+     *
      * @param context The coding agent context
      * @param language Language for the prompt (EN or ZH)
      * @return The rendered system prompt
@@ -23,10 +29,49 @@ class CodingAgentPromptRenderer {
             "ZH", "CN" -> CodingAgentTemplate.ZH
             else -> CodingAgentTemplate.EN
         }
-        
+
         // Convert context to variable table
         val variableTable = context.toVariableTable()
-        
+
+        // Compile template
+        val compiler = TemplateCompiler(variableTable)
+        return compiler.compile(template)
+    }
+
+    /**
+     * Render system prompt with dynamic tool list
+     *
+     * @param tools Available tools for the agent
+     * @param language Language for the prompt (EN or ZH)
+     * @return The rendered system prompt
+     */
+    fun renderSystemPrompt(tools: List<Tool>, language: String = "EN"): String {
+        // Get template based on language
+        val template = when (language.uppercase()) {
+            "ZH", "CN" -> CodingAgentTemplate.ZH
+            else -> CodingAgentTemplate.EN
+        }
+
+        // Create variable table with tools and default values
+        val variableTable = VariableTable()
+
+        // Add tool information for ${toolList}
+        val toolDescriptions = tools.map { tool ->
+            "- **${tool.name}**: ${tool.description}"
+        }.joinToString("\n")
+
+        variableTable.addVariable("toolList", VariableType.STRING, toolDescriptions, VariableScope.USER_DEFINED)
+        variableTable.addVariable("toolNames", VariableType.ARRAY, tools.map { it.name }, VariableScope.USER_DEFINED)
+
+        // Add default values for other template variables
+        variableTable.addVariable("osInfo", VariableType.STRING, Platform.getOSName(), VariableScope.BUILTIN)
+        variableTable.addVariable("projectPath", VariableType.STRING, "/project", VariableScope.BUILTIN)
+        variableTable.addVariable("timestamp", VariableType.STRING, Clock.System.now().toString(), VariableScope.BUILTIN)
+        variableTable.addVariable("currentFile", VariableType.STRING, "", VariableScope.BUILTIN)
+        variableTable.addVariable("buildTool", VariableType.STRING, "Auto-detected", VariableScope.BUILTIN)
+        variableTable.addVariable("shell", VariableType.STRING, Platform.getDefaultShell(), VariableScope.BUILTIN)
+        variableTable.addVariable("projectStructure", VariableType.STRING, "Will be analyzed during execution", VariableScope.BUILTIN)
+
         // Compile template
         val compiler = TemplateCompiler(variableTable)
         return compiler.compile(template)

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/Platform.kt

@@ -9,6 +9,9 @@ expect object Platform {
     val isJs: Boolean
     val isWasm: Boolean
     val isAndroid: Boolean
+
+    fun getOSName(): String
+    fun getDefaultShell(): String
 }
 
 /**

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/subagent/CodebaseInvestigatorAgent.kt

@@ -7,6 +7,7 @@ import cc.unitmesh.agent.model.ModelConfig
 import cc.unitmesh.agent.model.RunConfig
 import cc.unitmesh.agent.model.ToolConfig
 import cc.unitmesh.agent.tool.ToolResult
+import cc.unitmesh.agent.tool.ToolNames
 import cc.unitmesh.llm.KoogLLMService
 import kotlinx.serialization.Serializable
 
@@ -47,7 +48,7 @@ class CodebaseInvestigatorAgent(
     private val llmService: KoogLLMService
 ) : SubAgent<InvestigationContext, ToolResult.AgentResult>(
     AgentDefinition(
-        name = "CodebaseInvestigatorAgent",
+        name = ToolNames.CODEBASE_INVESTIGATOR,
         displayName = "Codebase Investigator",
         description = "Analyzes codebase structure and provides insights using code analysis",
         promptConfig = PromptConfig(

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/subagent/ErrorRecoveryAgent.kt

@@ -7,6 +7,7 @@ import cc.unitmesh.agent.model.PromptConfig
 import cc.unitmesh.agent.model.RunConfig
 import cc.unitmesh.agent.platform.GitOperations
 import cc.unitmesh.agent.tool.ToolResult
+import cc.unitmesh.agent.tool.ToolNames
 import cc.unitmesh.llm.KoogLLMService
 import kotlinx.serialization.Serializable
 import kotlinx.serialization.json.Json
@@ -335,7 +336,7 @@ $context
 
     companion object {
         private fun createDefinition() = AgentDefinition(
-            name = "error_recovery",
+            name = ToolNames.ERROR_RECOVERY,
             displayName = "Error Recovery SubAgent",
             description = "Analyzes command failures and provides recovery plans",
             promptConfig = PromptConfig(

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/subagent/LogSummaryAgent.kt

@@ -6,6 +6,7 @@ import cc.unitmesh.agent.model.ModelConfig
 import cc.unitmesh.agent.model.PromptConfig
 import cc.unitmesh.agent.model.RunConfig
 import cc.unitmesh.agent.tool.ToolResult
+import cc.unitmesh.agent.tool.ToolNames
 import cc.unitmesh.llm.KoogLLMService
 import kotlinx.serialization.Serializable
 import kotlinx.serialization.json.Json
@@ -343,7 +344,7 @@ Provide a JSON summary as specified in your system prompt.
 
     companion object {
         private fun createDefinition() = AgentDefinition(
-            name = "log_summary",
+            name = ToolNames.LOG_SUMMARY,
             displayName = "Log Summary SubAgent",
             description = "Summarizes long command outputs",
             promptConfig = PromptConfig(

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/tool/ToolNames.kt

@@ -28,6 +28,11 @@ object ToolNames {
     // Utility tools
     const val HELP = "help"
     const val VERSION = "version"
+
+    // SubAgent tools
+    const val ERROR_RECOVERY = "error-recovery"
+    const val LOG_SUMMARY = "log-summary"
+    const val CODEBASE_INVESTIGATOR = "codebase-investigator"
 
     /**
      * All available tool names
@@ -38,7 +43,8 @@ object ToolNames {
         SHELL, EXEC,
         EDIT_FILE, PATCH_FILE,
         FILE_INFO, DIR_INFO,
-        HELP, VERSION
+        HELP, VERSION,
+        ERROR_RECOVERY, LOG_SUMMARY, CODEBASE_INVESTIGATOR
     )
 
     /**
@@ -57,6 +63,13 @@ object ToolNames {
     val EXECUTION_TOOLS = setOf(
         SHELL, EXEC
     )
+
+    /**
+     * SubAgent tools for specialized tasks
+     */
+    val SUBAGENT_TOOLS = setOf(
+        ERROR_RECOVERY, LOG_SUMMARY, CODEBASE_INVESTIGATOR
+    )
 
     /**
      * Check if a tool name is valid

mpp-core/src/jsMain/kotlin/cc/unitmesh/agent/Platform.js.kt

@@ -6,4 +6,16 @@ actual object Platform {
     actual val isJs: Boolean = true
     actual val isWasm: Boolean = false
     actual val isAndroid: Boolean = false
+
+    actual fun getOSName(): String {
+        return js("typeof process !== 'undefined' ? process.platform : 'Browser'") as String
+    }
+
+    actual fun getDefaultShell(): String {
+        val platform = js("typeof process !== 'undefined' ? process.platform : 'unknown'") as String
+        return when (platform) {
+            "win32" -> "cmd"
+            else -> "bash"
+        }
+    }
 }

mpp-core/src/jvmMain/kotlin/cc/unitmesh/agent/Platform.jvm.kt

@@ -6,4 +6,13 @@ actual object Platform {
     actual val isJs: Boolean = false
     actual val isWasm: Boolean = false
     actual val isAndroid: Boolean = false
+
+    actual fun getOSName(): String {
+        return System.getProperty("os.name", "Unknown")
+    }
+
+    actual fun getDefaultShell(): String {
+        val osName = System.getProperty("os.name", "")
+        return if (osName.contains("Windows", ignoreCase = true)) "cmd" else "bash"
+    }
 }