Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modularized function generate_sampled_circuits #2619

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shivansh20128
Copy link
Contributor

Description

This PR aims at adding the modularized functions added in #2604.
I have added a use-case example for the function generate_sampled_circuits.
#Resolves #2605


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (cc33508) to head (4e4f295).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          92       92           
  Lines        4198     4198           
=======================================
  Hits         4145     4145           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shivansh20128
Copy link
Contributor Author

Shivansh20128 commented Dec 23, 2024

Hi! This is still a work in progress. Could you tell me if I should also add the use of combine_results function here? Thanks.

@purva-thakre
Copy link
Collaborator

purva-thakre commented Dec 23, 2024

Could you tell me if I should also add the use of combine_results function here?

Yes, as we want to show how a user can accomplish the same thing as what the execute_with_pec does behind the scenes but by using the modularized functions.

I created a similar section in the LRE user guide, if you want a more detailed outline: https://mitiq.readthedocs.io/en/stable/guide/lre-1-intro.html#step-by-step-application-of-lre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add modularized functions to the PEC user guide
2 participants