Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the ability to update all keys for a single API_ID #2081

Open
3 tasks done
perkinsjr opened this issue Sep 12, 2024 · 6 comments
Open
3 tasks done

Give the ability to update all keys for a single API_ID #2081

perkinsjr opened this issue Sep 12, 2024 · 6 comments
Labels
Core Team Feature New feature or request Needs Approval Needs approval from Unkey

Comments

@perkinsjr
Copy link
Collaborator

Preliminary Checks

Is your feature request related to a problem? Please describe.

In some cases a user may need to update all their keys for a specific API_ID. A good use case

  • Update ratelimits for all keys within an API_ID

Describe the solution

Create a new endpoint to allow updateKeys by API_ID

Describe alternatives you have considered (if any)

No response

Additional context

No response

@perkinsjr perkinsjr added Feature New feature or request Needs Approval Needs approval from Unkey labels Sep 12, 2024
Copy link

linear bot commented Sep 12, 2024

@harshsbhat
Copy link
Contributor

Can I work on this? If it gets approved and is not a core team feature let me know. I will upload a plan in a few minutes on how I will be tackling this.

@perkinsjr perkinsjr added Core Team and removed Needs Approval Needs approval from Unkey labels Sep 12, 2024
@perkinsjr
Copy link
Collaborator Author

Can I work on this? If it gets approved and is not a core team feature let me know. I will upload a plan in a few minutes on how I will be tackling this.

This will be core team and still need internal discussion

@perkinsjr perkinsjr added the Needs Approval Needs approval from Unkey label Sep 12, 2024
@harshsbhat
Copy link
Contributor

Can I work on this? If it gets approved and is not a core team feature let me know. I will upload a plan in a few minutes on how I will be tackling this.

This will be core team and still need internal discussion

Sure. Np!

@chronark
Copy link
Collaborator

Without further understanding the need for this, I'd be inclined to reject it.

There's too much that can go wrong

What happens when an api has thousands of keys and some updates fail while some succeed?

@perkinsjr
Copy link
Collaborator Author

This was a customer request, feel free to decline. Or leave open to see if anyone needs it and close in 3 mo.

Without further understanding the need for this, I'd be inclined to reject it.

There's too much that can go wrong

What happens when an api has thousands of keys and some updates fail while some succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Feature New feature or request Needs Approval Needs approval from Unkey
Projects
None yet
Development

No branches or pull requests

3 participants