Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More justification for verify key status codes #822

Closed
WilfredAlmeida opened this issue Jan 19, 2024 · 10 comments · Fixed by #2244
Closed

More justification for verify key status codes #822

WilfredAlmeida opened this issue Jan 19, 2024 · 10 comments · Fixed by #2244
Assignees
Labels
Documentation Improvements or additions to documentation Good first issue Good for newcomers Improvement Improve an existing feature 🕹️ 150 points 🕹️ oss.gg

Comments

@WilfredAlmeida
Copy link
Contributor

WilfredAlmeida commented Jan 19, 2024

Type of documentation issue

Other

Describe the problem and the proposed solution

For verify key, it's clear that these are key statuses & the http status will be 200, however, given similar names, its easy to get confused. Maybe a note at the bottom saying "These are key statuses, HTTP status will be 200" can be added. Just incase someone gets confused.

image

@WilfredAlmeida WilfredAlmeida added Documentation Improvements or additions to documentation Needs Approval Needs approval from Unkey labels Jan 19, 2024
Copy link

linear bot commented Jan 19, 2024

@chronark chronark removed Needs Approval Needs approval from Unkey Documentation Improvements or additions to documentation labels Jun 28, 2024
@perkinsjr perkinsjr added Documentation Improvements or additions to documentation Good first issue Good for newcomers Improvement Improve an existing feature labels Jul 13, 2024
@Pranavtej
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 7, 2024

Assigned to @Pranavtej! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Pranavtej
Copy link
Contributor

@WilfredAlmeida @chronark
can you please review this issue and validate?

@nilaygit-10721
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@parthmodi152
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@WilfredAlmeida
Copy link
Contributor Author

This isssue is a no-brainer fix that has already been implemented. I'm closing this now because I'm annoyed with the emails of people trying to get assigned an obviously assigned and fixed issue for the sake of point farming

Please create a new issue if the context if this issue needs to be revisited. Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Good first issue Good for newcomers Improvement Improve an existing feature 🕹️ 150 points 🕹️ oss.gg
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants