Skip to content

Commit 10ec517

Browse files
A few comment cases
1 parent 764c20e commit 10ec517

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

scanner_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,19 @@ var _ = Describe("Scanner", func() {
111111
},
112112
)
113113

114+
DescribeTable("Scan comment tokens",
115+
Entry(nil, "#", token.COMMENT),
116+
func(input string, expected token.Token) {
117+
buf := bytes.NewBufferString(input)
118+
s := make.NewScanner(buf)
119+
120+
more := s.Scan()
121+
122+
Expect(s.Token()).To(Equal(expected))
123+
Expect(more).To(BeTrueBecause("more to scan"))
124+
},
125+
)
126+
114127
It("should scan newline followed by token", func() {
115128
buf := bytes.NewBufferString("\n ident")
116129
s := make.NewScanner(buf)

token/token.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ func IsIdentifier(name string) bool {
279279
return false
280280
}
281281
switch name {
282-
case "(", ")", "{", "}", "$", ":", ",", "\n", "\t":
282+
case "(", ")", "{", "}", "$", ":", ",", "\n", "\t", "#":
283283
fallthrough
284284
case "=", ":=", "::=", ":::=", "?=", "!=":
285285
return false

token/token_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,7 @@ var _ = Describe("Token", func() {
514514
Entry(nil, "}"),
515515
Entry(nil, ":"),
516516
Entry(nil, "$"),
517+
Entry(nil, "#"),
517518
Entry(nil, ","),
518519
Entry(nil, "="),
519520
Entry(nil, ":="),

0 commit comments

Comments
 (0)