-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Start-Goal Points #2
Comments
Hi @SSebigo. Thanks for your question. So, the idea of yours is to randomly or manually set the coordinates of the entry and exit doors in the maze. The way I see it, this can be done by carving two walls on different sides of the maze field:
What you're suggesting looks to me like this:
Is this what you're looking for? What do you think about the first approach? I'm also curious what do you like to build such a map for if I may ask? |
That's exactly what I'm suggesting, in my use case I need to parse a file (for a game), if the start-goal are just dots in walls it's requires a bit of work on my end to find them but if they're S-G, then I can just search for these letters. So far, I've been generating mazes and placing the letters manually, it would be better if it could be generated directly with the maze, so the pipeline would be fully automated (generate -> solve -> test with bot). |
@SSebigo I see. This sounds interesting 👍 I think I can get it done. Perhaps, it can be a part of the public API of the GameMap struct. Thus both the lib and CLI can provide the feature to generate the start-goal positions. By the way, from what you said I'd hazard a guess you're using the CLI for generating mazes, aren't you? |
Yeah, I generate the maze into a file, then read the file inside Godot. |
@SSebigo That's great. I'll look into it this week |
@SSebigo Hi. I've managed to implement an MVP version of the feature you requested. Before I move further to covering new logic with unit tests and documenting the API changes, I'd be happy if you take a look at the changes I've made so far. It'd make a lot of sense if you actually integrate the new feature of How to test? CLI:
Lib:
If you encounter any issues or bugs, please let me know. |
I've tested the CLI and that's exactly what I had in mind. Haven't tested the lib yet, but if it used the same code as the CLI it should be good to go. |
@SSebigo Hi, this is great that you were able to test it and verified the results. The CLI uses the library public API, hence you can try using it for your plugin as well. I can see you've closed the issue, though the PR isn't merged yet and the new feature isn't covered with unit tests. I feel OK with finishing this feature and release a new minor version. I just need some time to do that. Simply put, we can reopen this and close once the PR is merged. WDYT? |
@unrenamed my bad, I forgot this feature was not on the main branch. Take your time, I'll work with the feature branch for now np. |
@SSebigo Great! I'll let you know when it's ready. By the way, how's the progress with your game? Have you already tried using the Godot Rust plugin to make |
Is there a way to automatically or manually define start-goal points, where for example the start point would be represented by a "S" and the goal by a "G" on the ASCII map?
The text was updated successfully, but these errors were encountered: