Use "<cluster name>:<addon name>" for Addon.eks external-name annotation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples |
1 similar comment
|
/test-examples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #7
This PR adds a patch statement for the
Addon.ekscomposed resource, which sets its external-name annotation to<EKS cluster name>:aws-ebs-csi-driver. Initially, the external-name is justaws-ebs-csi-driver, as it was previously and once thestatus.eks.clusterNameis available at thexeksXR, it's patched with the specified syntax.If there's a way in compositions to directly patch from the
specof the composed resource, or directly from one composed (Cluster.eks) to another (Addon.eks), I think we had better use it. Currently, the data flow for the proposed change isCluster.ekeMR ->xeksXR ->Addon.eks.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Via uptest: https://github.com/upbound/configuration-aws-eks/actions/runs/7037818700