Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubyzip dependency #143

Open
mfaughn opened this issue Oct 20, 2020 · 3 comments
Open

rubyzip dependency #143

mfaughn opened this issue Oct 20, 2020 · 3 comments

Comments

@mfaughn
Copy link

mfaughn commented Oct 20, 2020

RSpec passes fine with RubyZip 2.3. Would be easier to integrate with other stuff if the dependency were updated to reflect this.
@kpmueller
Copy link

This dependency is very old.. would you accept a PR it was created?

@mfaughn
Copy link
Author

mfaughn commented Jan 9, 2021

This dependency is very old.. would you accept a PR it was created?

It looks like there already is a PR concerning RubyZip 2.

@geoffharcourt
Copy link

We've been using this branch/PR since December 2019 without issue: #129

@geoffharcourt geoffharcourt mentioned this issue Mar 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Rubyzip 2.0
3 participants
@geoffharcourt @mfaughn @kpmueller