Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit 0d2b46f

Browse files
committed
normalize mac address from scapy
1 parent 92fb593 commit 0d2b46f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

roles/arp/files/apate/lib/apate_redis.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,14 @@ def check_device_disabled(self, mac):
267267
"""
268268
# True if devices is disabled
269269
# return self.redis.get(self._get_device_name(mac, network or self.network, enabled=False)) is not None
270-
return self.redis.sismember(self.get_excluded_key(), mac)
270+
return self.redis.sismember(self.get_excluded_key(), str(mac).lower())
271271

272272
def _toggle_device(self, mac, ip, network, enabled):
273273
# add new device first and delete old device afterwards
274274
# this is done to avoid race conditions
275275
# self.add_device(mac, self.get_device_ip(mac, network, enabled=not enabled), network, enabled=enabled, force=True)
276276
# self.remove_device(mac, network, enabled=not enabled)
277+
mac = str(mac).lower()
277278
if not enabled:
278279
self.redis.sadd(self.get_excluded_key(), mac)
279280
else:

roles/fingerprinting/files/registrar/lib/misc_thread.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,10 @@ def run(self):
6363
if devices:
6464
ans, unans = arping(devices, iface=None, verbose=0)
6565
for device in ans:
66-
if check_preconditions(device[1][ARP].psrc, device[1][ARP].hwsrc):
67-
insert_or_update_fingerprint(self.conn, ip=device[1][ARP].psrc, mac=device[1][ARP].hwsrc)
66+
ip_addr = device[1][ARP].psrc
67+
mac_addr = str(device[1][ARP].hwsrc).lower()
68+
if check_preconditions(ip_addr, mac_addr):
69+
insert_or_update_fingerprint(self.conn, ip=ip_addr, mac=mac_addr)
6870

6971
self.logger.info("checked no mode devices: " + str(devices))
7072

0 commit comments

Comments
 (0)