Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable issues when using RTD Theme #305

Closed
twodrops opened this issue Jun 25, 2021 · 7 comments · Fixed by #360 or #385
Closed

Datatable issues when using RTD Theme #305

twodrops opened this issue Jun 25, 2021 · 7 comments · Fixed by #360 or #385
Assignees
Labels
Milestone

Comments

@twodrops
Copy link
Collaborator

Some points were reported as part of this issue
#271 (comment)

When using Datatables with RTD,

  • The head columns don't have the same width as the content columns.
  • When scrolling head and content is not align.

118938027-723b2b00-b94e-11eb-97a1-63e0179e47ee

@danwos
Copy link
Member

danwos commented Jul 20, 2021

The read_the_docs theme related issues really drive me crazy :/
This theme is doing so much voodoo, that it is hard or even impossible to provide workarounds for it.

So rtd is wrapping each table in an extra div with class wy-table-responsive (via online javascript manipulation!).
Then some values for div.wy-table-responsive get set via css and I have the feeling also via js.

When I deactivate the rtd js file theme.js for the documentation, all looks good.

So it's impossible to define something on css level, if it gets overwritten by js code later.

I will need to discuss this issue with the rtd-developers and maybe discuss a common way of how a table (created by extension) can be exclude from this kind of handling.

@danwos danwos modified the milestones: 0.7.1, 0.7.2 Jul 20, 2021
@danwos
Copy link
Member

danwos commented Jul 21, 2021

Created bug report: readthedocs/sphinx_rtd_theme#1179

@twodrops
Copy link
Collaborator Author

Perfect bug report. Thanks!!

@danwos danwos added the theme label Aug 17, 2021
@danwos
Copy link
Member

danwos commented Aug 24, 2021

Same problem for the Sphinx Material theme.
But the reason and a solution would look completely different:
Bug issue: bashtage/sphinx-material#119

@danwos
Copy link
Member

danwos commented Aug 24, 2021

PR is out for RTD: readthedocs/sphinx_rtd_theme#1218

danwos added a commit that referenced this issue Aug 24, 2021
danwos added a commit that referenced this issue Aug 24, 2021
@danwos danwos self-assigned this Aug 24, 2021
danwos added a commit that referenced this issue Aug 25, 2021
@danwos
Copy link
Member

danwos commented Aug 25, 2021

PR on RTD side is on hold and shall be merged with release 1.1. Currently 1.0 gets prepared, so this may take a while 😞 .

In the meantime, this fork contains the change and can be installed by hand to get it working:
https://github.com/useblocks/sphinx_rtd_theme/tree/danwos/wy-table-exclude

danwos added a commit that referenced this issue Aug 25, 2021
@twodrops
Copy link
Collaborator Author

twodrops commented Oct 6, 2021

#304 is fixed as part of this. The problem mentioned in the description of this issue is still there. Therefore, it can be reopened I guess.

@danwos danwos reopened this Oct 8, 2021
danwos added a commit that referenced this issue Oct 8, 2021
danwos added a commit that referenced this issue Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants