From 44668c537e010e29fc42a25a17e1dedef018de7f Mon Sep 17 00:00:00 2001 From: Matthieu Nicolescu Date: Tue, 5 Mar 2024 23:35:22 +0100 Subject: [PATCH 1/4] fix: workflow name of tf modules validation --- .github/workflows/tf-modules-validation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tf-modules-validation.yml b/.github/workflows/tf-modules-validation.yml index 56e805a..e62b1e1 100644 --- a/.github/workflows/tf-modules-validation.yml +++ b/.github/workflows/tf-modules-validation.yml @@ -1,4 +1,4 @@ -name: TF Modules - Validaton +name: TF Modules - Validation on: push: From 727d74789fda6bcd264f065ad3f62c1cc5a8079f Mon Sep 17 00:00:00 2001 From: Matthieu Nicolescu Date: Tue, 5 Mar 2024 23:36:46 +0100 Subject: [PATCH 2/4] fix: workflow name of tf modules validation --- .github/workflows/tf-modules-validation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tf-modules-validation.yml b/.github/workflows/tf-modules-validation.yml index e62b1e1..65a71a6 100644 --- a/.github/workflows/tf-modules-validation.yml +++ b/.github/workflows/tf-modules-validation.yml @@ -14,7 +14,7 @@ on: workflow_dispatch: concurrency: - group: ${{ github.workflow }}-${{ github.ref }} + group: ${{ github.workflow }} cancel-in-progress: false permissions: From 5e4a151e84bb9405f5901c99518888d414d86ce2 Mon Sep 17 00:00:00 2001 From: Matthieu Nicolescu Date: Wed, 6 Mar 2024 00:28:09 +0100 Subject: [PATCH 3/4] fix: set terraform version to 1.6.2 --- .github/workflows/tf-modules-validation.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tf-modules-validation.yml b/.github/workflows/tf-modules-validation.yml index 65a71a6..9615701 100644 --- a/.github/workflows/tf-modules-validation.yml +++ b/.github/workflows/tf-modules-validation.yml @@ -46,6 +46,7 @@ jobs: ARM_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} ARM_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} ARM_USE_OIDC: "true" + TERRAFORM_VERSION: "1.6.2" strategy: fail-fast: false matrix: @@ -61,7 +62,7 @@ jobs: uses: hashicorp/setup-terraform@v3 with: terraform_wrapper: false - terraform_version: latest + terraform_version: ${{ env.TERRAFORM_VERSION }} - name: Terraform Version run: terraform version @@ -96,7 +97,7 @@ jobs: - 'terraform/modules/${{ matrix.modules }}/**' - name: Terraform Test - if: steps.changes.outputs.module == 'true' || (github.event_name == 'push' && github.ref == 'refs/heads/main') || (github.event_name == 'workflow_dispatch') + if: steps.changes.outputs.module == 'true' || (github.event_name == 'workflow_dispatch') run: | OUTPUT=$(terraform test) echo "$OUTPUT" From 4db15b8d878c000803c708f46c689f77325dae0a Mon Sep 17 00:00:00 2001 From: Matthieu Nicolescu Date: Wed, 6 Mar 2024 00:30:58 +0100 Subject: [PATCH 4/4] fix: update aks version to 1.28.5 --- terraform/modules/az-aks/tests/cluster_creation.tftest.hcl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/terraform/modules/az-aks/tests/cluster_creation.tftest.hcl b/terraform/modules/az-aks/tests/cluster_creation.tftest.hcl index 3a16785..c7bc936 100644 --- a/terraform/modules/az-aks/tests/cluster_creation.tftest.hcl +++ b/terraform/modules/az-aks/tests/cluster_creation.tftest.hcl @@ -18,7 +18,7 @@ run "plan" { resource_group_name = run.setup.resource_group_name name = "az-aks-cluster" configuration = { - version = "1.27.3" + version = "1.28.5" sku = "Free" private_cluster = true user_assigned_identity_id = run.setup.assigned_identity_id @@ -99,7 +99,7 @@ run "apply" { resource_group_name = run.setup.resource_group_name name = "az-aks-cluster" configuration = { - version = "1.27.3" + version = "1.28.5" sku = "Free" private_cluster = true user_assigned_identity_id = run.setup.assigned_identity_id