Fixing cryfs issues in non interactive way

Author: usma0118

cryfs/Dockerfile

@@ -8,19 +8,21 @@ ENV CRYFS_FRONTEND="noninteractive" \
     CRYFS_FRONTEND=noninteractive \
     CRYFS_NO_UPDATE_CHECK=true \
     TINI_SUBREAPER="" \
-    DEBIAN_FRONTEND=noninteractive
-RUN apt-get update && apt-get --no-install-recommends install -y build-essential
+    DEBIAN_FRONTEND=noninteractive \
+    CRYFS_LOCAL_STATE_DIR=/data
+VOLUME [ "/encrypted", "/decrypted", "/data" ]
+RUN apt-get update --no-install-recommends && apt-get upgrade --no-install-recommends -y
+#&& apt-get --no-install-recommends install -y build-essential
 RUN apt-get --no-install-recommends install cryfs fuse tini -y &&\
     useradd -s /usr/sbin/nologin -m secretfs && passwd -d secretfs &&\
     echo 'nonroot ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers &&\
     echo user_allow_other >> /etc/fuse.conf &&\
     apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 WORKDIR /app
-VOLUME [ "/encrypted", "/decrypted" ]
-
 COPY run.sh /usr/bin/run.sh
 RUN chmod +x /usr/bin/run.sh
 USER nobody:nobody
+
 # Set the entrypoint and default command
 ENTRYPOINT ["/usr/bin/tini", "-g", "--"]
 CMD ["/usr/bin/run.sh"]

cryfs/run.sh

@@ -1,15 +1,15 @@
 #!/bin/bash
 set -e
-
-ENC_PATH=/encrypted
-DEC_PATH=/decrypted
+set -o nounset
+declare -r ENC_PATH=/encrypted
+declare -r DEC_PATH=/decrypted
 
 # Define colors
-RED='\033[0;31m'
-GREEN='\033[0;32m'
-YELLOW='\033[0;33m'
-BLUE='\033[0;34m'
-RESET='\033[0m'
+declare -r RED='\033[0;31m'
+declare -r GREEN='\033[0;32m'
+declare -r YELLOW='\033[0;33m'
+declare -r BLUE='\033[0;34m'
+declare -r RESET='\033[0m'
 
 # Debug function with colorized output
 debug() {
@@ -62,19 +62,17 @@ function sighup_handler {
 trap sigterm_handler SIGINT SIGTERM
 trap sighup_handler SIGHUP
 
-debug "$(mask_string "$PASSWD")"
-
 _user="$(id -u -n)"
 _uid="$(id -u)"
 debug "Running as $_user with UID: $_uid"
-
+sleep infinity
 unset pid
 if [ ! -z "$PASSWD" ]; then
-  debug "mounting ${ENC_PATH} on ${DEC_PATH}"
+  info "mounting ${ENC_PATH} on ${DEC_PATH} with password: "$(mask_string "$PASSWD", "*")""
   echo "${PASSWD}" | cryfs -o ${MOUNT_OPTIONS} -f "${ENC_PATH}" "${DEC_PATH}" & pid=($!)
 else
 	cryfs ${ENCFS_OPTS} -o ${MOUNT_OPTIONS} -f "${ENC_PATH}" "${DEC_PATH}" & pid=($!)
-  info "mounting ${ENC_PATH} on ${DEC_PATH}"
+  info "mounting ${ENC_PATH} on ${DEC_PATH} without password"
 fi
 wait "${pid}"