Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SST1RSoXSDB: use_chunked_loading and catalog_kwargs incompatible with externally supplied catalog #71

Closed
pbeaucage opened this issue Feb 20, 2023 · 0 comments · Fixed by #80
Closed

SST1RSoXSDB: use_chunked_loading and catalog_kwargs incompatible with externally supplied catalog #71

pbeaucage opened this issue Feb 20, 2023 · 0 comments · Fixed by #80
Assignees
@pbeaucage

Comments

@pbeaucage
Copy link
Collaborator

use_chunked_loading simply sets the catalog_kwargs field structure_clients to "dask"

However, if the user passes in a pre-constructed catalog with catalog=, then the catalog_kwargs is not used.

The loader should warn/error if either use_chunked_loading or catalog_kwargs is used when an external catalog is supplied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbeaucage pbeaucage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SST1RSoXS: error if conflicting constructor arguments are provided usnistgov/PyHyperScattering
1 participant
@pbeaucage