Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Marshal using new Swift features #135

Open
olejnjak opened this issue Jan 23, 2019 · 1 comment
Open

Simplify Marshal using new Swift features #135

olejnjak opened this issue Jan 23, 2019 · 1 comment

Comments

@olejnjak
Copy link

Hi,

I was wondering whether it would be possible to simplify Marshal implementation using new Swift features like conditional protocol conformance. This would also simplify creating 3rd party extensions above Marshal.

This would e.g. allow [ValueType] to conform ValueType so lot of code could be then reused/deleted.

I'm open to implementing it but don't wanna waste time on something that wouldn't have a chance to be merged.

Thanks

@bwhiteley
Copy link
Contributor

I like the idea of reducing duplicated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants