From 0033092978baa88008f5a99ba39e3c3c119a1706 Mon Sep 17 00:00:00 2001 From: Uwe Seimet Date: Mon, 11 Dec 2023 19:01:03 +0100 Subject: [PATCH] Fix Sonar issues --- cpp/buses/rpi_bus.cpp | 4 ++-- cpp/buses/rpi_bus.h | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/cpp/buses/rpi_bus.cpp b/cpp/buses/rpi_bus.cpp index f0c3de4a..2cccbd5a 100644 --- a/cpp/buses/rpi_bus.cpp +++ b/cpp/buses/rpi_bus.cpp @@ -531,12 +531,12 @@ bool RpiBus::GetREQ() const return GetSignal(PIN_REQ); } -void RpiBus::SetREQ(bool ast) +inline void RpiBus::SetREQ(bool ast) { SetSignal(PIN_REQ, ast); } -uint8_t RpiBus::GetDAT() +inline uint8_t RpiBus::GetDAT() { return static_cast(Acquire() >> PIN_DT0); } diff --git a/cpp/buses/rpi_bus.h b/cpp/buses/rpi_bus.h index bd5562e9..325b7b15 100644 --- a/cpp/buses/rpi_bus.h +++ b/cpp/buses/rpi_bus.h @@ -95,10 +95,10 @@ class RpiBus : public GpioBus void SetIO(bool ast) override; bool GetREQ() const override; - inline void SetREQ(bool ast) override; + void SetREQ(bool ast) override; - inline uint8_t GetDAT() override; - inline void SetDAT(uint8_t) override; + uint8_t GetDAT() override; + void SetDAT(uint8_t) override; bool WaitREQ(bool ast) override { @@ -150,16 +150,16 @@ class RpiBus : public GpioBus #ifndef NO_IRQ_DISABLE // Interrupt enabled state - volatile uint32_t irptenb; // NOSONAR volatile needed for register access + volatile uint32_t irptenb; // Interupt control target CPU - volatile int tintcore; // NOSONAR volatile needed for register access + volatile int tintcore; // Interupt control - volatile uint32_t tintctl; // NOSONAR volatile needed for register access + volatile uint32_t tintctl; // GICC priority setting - volatile uint32_t giccpmr; // NOSONAR volatile needed for register access + volatile uint32_t giccpmr; #endif // GIC Interrupt distributor register