Skip to content

Commit 18ce6a9

Browse files
committed
fix: remove --_grid-colstart when removing <br>
1 parent f2a2335 commit 18ce6a9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/form-layout/src/vaadin-form-layout-mixin.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,8 @@ export const FormLayoutMixin = (superClass) =>
374374
if (resetColumn) {
375375
child.style.setProperty('--_grid-colstart', 1);
376376
resetColumn = false;
377+
} else {
378+
child.style.removeProperty('--_grid-colstart');
377379
}
378380
});
379381
}

packages/form-layout/test/form-layout.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -519,14 +519,14 @@ describe('form layout', () => {
519519

520520
it('should update grid-column-start after adding <br>', async () => {
521521
const br = document.createElement('br');
522-
items[0].after(br);
522+
layout.insertBefore(br, items[1]);
523523
await nextRender(layout);
524524
expect(getComputedStyle(items[1]).gridColumnStart).to.equal('1');
525525
});
526526

527527
it('should update grid-column-start after removing <br>', async () => {
528528
const br = document.createElement('br');
529-
items[0].after(br);
529+
layout.insertBefore(br, items[1]);
530530
await nextRender(layout);
531531

532532
br.remove();

0 commit comments

Comments
 (0)