Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions Test, Verify require Lint #20

Closed
3esmit opened this issue Feb 26, 2024 · 3 comments
Closed

GH Actions Test, Verify require Lint #20

3esmit opened this issue Feb 26, 2024 · 3 comments

Comments

@3esmit
Copy link

3esmit commented Feb 26, 2024

Why is this the case?

@0x-r4bbit
Copy link
Collaborator

GH Actions simply run all jobs that are defined in our GitHub workflow.
These are:

  1. lint
  2. build
  3. test
  4. coverage
  5. verify

In that order. You can find the workflows here: https://github.com/vacp2p/foundry-template/blob/main/.github/workflows/ci.yml#L14

These tasks are executed on every pull request to ensure quality.
Other than that, there's no inherent reason why test and verify require linting.
I guess the thinking here is: "If it doesn't even pass the linter we don't even need to test it."

We can change this and have it not be a requirement for the subsequent tasks if this is too annoying.

@3esmit
Copy link
Author

3esmit commented Feb 27, 2024

Its annoying if lint have some bug as happened in #21

@3esmit
Copy link
Author

3esmit commented Feb 28, 2024

ok

@3esmit 3esmit closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants