Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to ensure lock() can't be called when there's no stake #126

Closed
0x-r4bbit opened this issue Feb 19, 2025 · 0 comments · Fixed by #129
Closed

Add a test to ensure lock() can't be called when there's no stake #126

0x-r4bbit opened this issue Feb 19, 2025 · 0 comments · Fixed by #129
Labels
2025q1 commitment: staking-protocol-refinement task: staking-protocol-refinement:bug-fixing
Milestone
2025q1-staking-pr...

Comments

@0x-r4bbit
Copy link
Collaborator

Currently it looks like one could call lock() on a vault that doesn't have any stake in it.

It likely wouldn't cause any harm, other than just locking up the vault for no good reason.
We should prevent this from happening
0x-r4bbit added a commit that referenced this issue Feb 19, 2025
@0x-r4bbit
test(RewardsStreamerMP): ensure lock() reverts when vault is empty
2a7415f 
Closes #126
@0x-r4bbit 0x-r4bbit mentioned this issue Feb 19, 2025
Merged
3 tasks
0x-r4bbit added a commit that referenced this issue Feb 19, 2025
@0x-r4bbit
test(RewardsStreamerMP): ensure lock() reverts when vault is empty
f484eed 
Closes #126
0x-r4bbit added a commit that referenced this issue Feb 19, 2025
@0x-r4bbit
test(RewardsStreamerMP): ensure lock() reverts when vault is empty
b79a023 
Closes #126
@0x-r4bbit 0x-r4bbit mentioned this issue Feb 19, 2025
Open
0x-r4bbit added a commit that referenced this issue Feb 19, 2025
@0x-r4bbit
test(RewardsStreamerMP): ensure lock() reverts when vault is empty
486e9c5 
Closes #126
0x-r4bbit added a commit that referenced this issue Feb 19, 2025
@0x-r4bbit
test(RewardsStreamerMP): ensure lock() reverts when vault is empty
59226ef 
Closes #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2025q1 commitment: staking-protocol-refinement task: staking-protocol-refinement:bug-fixing
Projects
Tasks - Smart Contracts
Status: Done
Milestone
2025q1-staking-protocol-refinement
Development

Successfully merging a pull request may close this issue.

test(RewardsStreamerMP): ensure lock() reverts when vault is empty vacp2p/staking-reward-streamer
1 participant
@0x-r4bbit