feat(RewardsStreamerMP): allow vaults to migrate to other vaults #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
feat/vault-migration
branch
from
0ef86a7 to
64a3d28
Compare
gravityblast
approved these changes
Feb 19, 2025
0x-r4bbit
force-pushed
the
feat/vault-migration
branch
from
64a3d28 to
a2ae036
Compare
This commit introduces a function `migrateToVault(address)` that allows `StakeVault`s to migrate to other `StakeVault` instances. The idea is that, when an upgrade was done on the stake manager, it might introduces functions that can't be accessed through the stake vaults that are out there. Users will have to create new stake vault instances that provide the necessary functionality. `migrateToVault()` allows them to do so. Closes #127
0x-r4bbit
force-pushed
the
feat/vault-migration
branch
from
a2ae036 to
7eb7518
Compare
0x-r4bbit
force-pushed
the
feat/vault-migration
branch
from
90dbfb0 to
c2a6ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a function
migrateToVault(address)that allowsStakeVaults to migrate to otherStakeVaultinstances.The idea is that, when an upgrade was done on the stake manager, it might introduces functions that can't be accessed through the stake vaults that are out there.
Users will have to create new stake vault instances that provide the necessary functionality.
migrateToVault()allows them to do so.Closes #127
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?