Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accounts to exit the system #66

Closed
0x-r4bbit opened this issue Oct 18, 2024 · 2 comments · Fixed by #72 or #78
Closed

Allow accounts to exit the system #66

0x-r4bbit opened this issue Oct 18, 2024 · 2 comments · Fixed by #72 or #78
Assignees
@0x-r4bbit
Labels
commitment: staking-protocol-v1 task: staking-v1:merging-existing-solutions
Milestone
2024q4-staking-pr...

Comments

@0x-r4bbit
Copy link
Collaborator

Once #14 is done with its most minimal basic functionality, we need to teach the reward streamer the notion of "exiting" the system.

In the previous protocol, this was done via a leave() function.
We probably want a similar one in the StakeVault that lives in this repository.
@0x-r4bbit 0x-r4bbit added this to the staking-protocol-v1 milestone Oct 18, 2024
@0x-r4bbit 0x-r4bbit mentioned this issue Oct 18, 2024
Merged
3 tasks
@0x-r4bbit 0x-r4bbit self-assigned this Oct 24, 2024
@0x-r4bbit 0x-r4bbit moved this from Todo to In Progress in Tasks - Smart Contracts Oct 24, 2024
@0x-r4bbit
Copy link
Collaborator Author

Realized that leaving the system only makes sense when there's upgradeability in place.

So this is somewhat blocked by #20

@3esmit
Copy link
Contributor

3esmit commented Oct 25, 2024

Related to logos-co/staking#148

0x-r4bbit added a commit that referenced this issue Oct 28, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce emergency mode and ability to leave
4b24f1e 
This adds a new emergency mode that can be enabled by the owner of the
system. When in emergency mode, stakers or `StakeVault`s can leave the
system immediately.

Closes #66
@0x-r4bbit 0x-r4bbit mentioned this issue Oct 28, 2024
Merged
3 tasks
0x-r4bbit added a commit that referenced this issue Oct 28, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce emergency mode and ability to leave
d5888dd 
This adds a new emergency mode that can be enabled by the owner of the
system. When in emergency mode, stakers or `StakeVault`s can leave the
system immediately.

Closes #66
0x-r4bbit added a commit that referenced this issue Oct 29, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce emergency mode and ability to leave
2f4b5a0 
This adds a new emergency mode that can be enabled by the owner of the
system. When in emergency mode, stakers or `StakeVault`s can leave the
system immediately.

Closes #66
0x-r4bbit added a commit that referenced this issue Oct 30, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce emergency mode and ability to leave
9e1dcaf 
This adds a new emergency mode that can be enabled by the owner of the
system. When in emergency mode, stakers or `StakeVault`s can leave the
system immediately.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 26, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce emergency mode and ability to leave
d883a7a 
This adds a new emergency mode that can be enabled by the owner of the
system. When in emergency mode, stakers or `StakeVault`s can leave the
system immediately.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 27, 2024
@0x-r4bbit
feat(RewardStreamerMP): add emergency mode so users can exit the system
cfb50de 
This adds a new emergency mode that can be enabled by the owner of the system.
When in emergency mode, stakers or `StakeVault`s can leave the system immediately.

This also applies when there was a malicious upgrade and a call to
`emergencyModeEnabled()` panics.

To have this in a fully secure manner, we still have to add the counter
part of "leaving" the system. This will allow users that don't agree
with a (malicious) upgrade to get their funds out of the vaults
regardless.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 27, 2024
@0x-r4bbit
feat(RewardStreamerMP): add emergency mode so users can exit the system
f5109a9 
This adds a new emergency mode that can be enabled by the owner of the system.
When in emergency mode, stakers or `StakeVault`s can leave the system immediately.

This also applies when there was a malicious upgrade and a call to
`emergencyModeEnabled()` panics.

To have this in a fully secure manner, we still have to add the counter
part of "leaving" the system. This will allow users that don't agree
with a (malicious) upgrade to get their funds out of the vaults
regardless.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 27, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
18fe9d7 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade (upgradeability lands in future
changes).

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
@0x-r4bbit 0x-r4bbit mentioned this issue Nov 27, 2024
Closed
3 tasks
0x-r4bbit added a commit that referenced this issue Nov 28, 2024
@0x-r4bbit
feat(RewardStreamerMP): add emergency mode so users can exit the system
ff84621 
This adds a new emergency mode that can be enabled by the owner of the system.
When in emergency mode, stakers or `StakeVault`s can leave the system immediately.

This also applies when there was a malicious upgrade and a call to
`emergencyModeEnabled()` panics.

To have this in a fully secure manner, we still have to add the counter
part of "leaving" the system. This will allow users that don't agree
with a (malicious) upgrade to get their funds out of the vaults
regardless.

Closes #66
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tasks - Smart Contracts Nov 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tasks - Smart Contracts Nov 28, 2024
0x-r4bbit added a commit that referenced this issue Nov 28, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
7ad3428 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade (upgradeability lands in future
changes).

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 28, 2024
@0x-r4bbit
feat(RewardStreamerMP): add emergency mode so users can exit the system
160e839 
This adds a new emergency mode that can be enabled by the owner of the system.
When in emergency mode, stakers or `StakeVault`s can leave the system immediately.

This also applies when there was a malicious upgrade and a call to
`emergencyModeEnabled()` panics.

To have this in a fully secure manner, we still have to add the counter
part of "leaving" the system. This will allow users that don't agree
with a (malicious) upgrade to get their funds out of the vaults
regardless.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 28, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
7eeb66c 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade (upgradeability lands in future
changes).

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 29, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
175e3b5 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
@0x-r4bbit 0x-r4bbit mentioned this issue Nov 29, 2024
Merged
0x-r4bbit added a commit that referenced this issue Nov 29, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
3e6c25e 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
0x-r4bbit added a commit that referenced this issue Nov 29, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
ec2dc08 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
0x-r4bbit added a commit that referenced this issue Dec 1, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
24a389a 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
0x-r4bbit added a commit that referenced this issue Dec 1, 2024
@0x-r4bbit
feat(RewardsStreamerMP): introduce leave() function
fcfe72d 
This function allows users to `leave()` the system if they can't or
don't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.

In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.

The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or, `leave()`
the system at which point it will try to perform a benign `leave()`
operation and then move the funds out of the vault.

Closes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x-r4bbit 0x-r4bbit

Labels
commitment: staking-protocol-v1 task: staking-v1:merging-existing-solutions
Projects
Tasks - Smart Contracts
Status: Done
Milestone
2024q4-staking-protocol-v1
2 participants
@3esmit @0x-r4bbit