Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(RewardsStreamerMP): remove unnecessary writes to `account.las… #91

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

0x-r4bbit
Copy link
Collaborator

…tMPupdateTime`

Whenever account.lastMPupdateTime is set, we also call _updateAccountMP() before that, which never reverts, so the value set there will never differ from the ones we set later explicitly.

Closes #80

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran pnpm adorno?
  • Ran pnpm verify?

…tMPupdateTime`

Whenever `account.lastMPupdateTime` is set, we also call
`_updateAccountMP()` before that, which never reverts, so the value set
there will never differ from the ones we set later explicitly.

Closes #80
@0x-r4bbit 0x-r4bbit merged commit be89292 into main Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Repeated write on account.lastMPUpdateTime
2 participants