feat(RewardsStreamerMP.t.sol): Make tests use calc functions and test… #83
Conversation
|
Currently this only affects functions related to MP, but all functions that are using magic numbers should have their own calculation function, which is tested by itself. Also, not all MPs are yet changed to use the calculation functions, so this is a WIP and I expect to finish this week. |
|
@3esmit this one needs some |
test/RewardsStreamerMP.t.sol
Outdated
| @@ -760,7 +839,7 @@ contract StakeTest is RewardsStreamerMPTest { | |||
| ); | |||
|
|
|||
| uint256 currentTime = vm.getBlockTimestamp(); | |||
| uint256 timeToMaxMP = _calculateTimeToMPLimit(stakeAmount); | |||
| uint256 timeToMaxMP = _calculateTimeToMP(stakeAmount, totalMaxMP - totalMP); | |||
There was a problem hiding this comment.
Any reason this is changed? I think reading "calculate time to max MP" is more intuitive than what this change is doing.
There was a problem hiding this comment.
Because calculateTimeToMP is more generic, and can be reused for other tests. While TimeToMPLimit would hardcode this function to always calculate time to max mp.
There was a problem hiding this comment.
We should at least rename this. "time to MP" doesn't make sense. I no longer understand what the function is doing without looking at its source.
test/RewardsStreamerMP.t.sol
Outdated
| return timeInSeconds; | ||
| } | ||
|
|
||
| function _calculateTimeToMP(uint256 amount, uint256 target) internal view returns (uint256) { |
There was a problem hiding this comment.
We should probably rename this. "calculate time to MP" doesn't make a lot of sense
There was a problem hiding this comment.
renamed to _calculateTimeToAccureMP
3esmit
force-pushed
the
fix/tests
branch
3 times, most recently
from
781c3ea to
3f1c79f
Compare
| // wait for 1 year | ||
| uint256 currentTime = vm.getBlockTimestamp(); | ||
| vm.warp(currentTime + (365 days)); | ||
|
|
||
| vm.warp(currentTime + (warpLength)); |
There was a problem hiding this comment.
I thnk warplength is not necessary here. It doesn't add any value.
… those functions chore(linter): added solhint-disable-next-line max-line-length to circumvent bug in linter chore(RewardsStreamerMP.t.sol): rename _calculateTimeToMP -> _calculateTimeToAccureMP
… those functions
Description
Fixes #81
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?