import foundry template #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityblast
force-pushed
the
foundry-template-2
branch
6 times, most recently
from
2ada081
to
9a618b8
Compare
0x-r4bbit
reviewed
Sep 24, 2024
.github/scripts/rename.sh
Outdated
|
|
||
| # Rename instances of "vacp2p/foundry-template" to the new repo name in README.md for badges only | ||
| sedi "/gha/ s|vacp2p/foundry-template|"${GITHUB_REPOSITORY}"|;" "README.md" | ||
| sedi "/gha-badge/ s|vacp2p/foundry-template|"${GITHUB_REPOSITORY}"|;" "README.md" |
There was a problem hiding this comment.
We don't need this file here.
package.json
Outdated
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "name": "@logos-co/staking-rewards-streamer", | |||
There was a problem hiding this comment.
Nitpick: should prolly be @vacp2p here
0x-r4bbit
force-pushed
the
foundry-template-2
branch
2 times, most recently
from
c73a57e
to
ab0ae6a
Compare
|
@gravityblast FYI I'm updating this PR according to my comments and making sure it passes on CI |
0x-r4bbit
force-pushed
the
foundry-template-2
branch
from
ab0ae6a
to
0c29aa1
Compare
0x-r4bbit
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.