Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update url for just_gtfs submodule #3994

Closed
mesozoic-drones opened this issue Mar 1, 2023 · 6 comments
Closed

Update url for just_gtfs submodule #3994

mesozoic-drones opened this issue Mar 1, 2023 · 6 comments

Comments

@mesozoic-drones
Copy link
Contributor

Hello! I am the maintainer of just_gtfs library for reading & writing of GTFS feeds. This library is used as a submodule in Valhalla.

@nilsnolde recently opened 2 issues in mapsme/just_gtfs repo:
mapsme/just_gtfs#17
mapsme/just_gtfs#19

The problem is that just_gtfs is the part of the MAPS.ME project which is not supported anymore. I can't push to master of mapsme/just_gtfs (and nobody of the original MAPS.ME team can).

But I want to improve and develop just_gtfs library so I propose to use my personal (and historically original) version:
https://github.com/mesozoic-drones/just_gtfs

Let's update url for just_gtfs in Valhalla's submodules!

P.S.
I've fixed the first bug found by @nilsnolde and this fix is already in master covered by test.

@nilsnolde
Copy link
Member

Great thanks. I accepted your invitation to the repo, thanks. I can try to help a bit here and there.

I'm kinda confused about the whole maps.me history 😅

Maybe you want to remove that fork and set up a real repository for that? If maps.me abandoned the project, IMHO a fresh start could be better? Also makes it more obvious for other people who want to use it.

@kevinkreiser
Copy link
Member

another option i would offer would be to even move the project into the valhalla organization as its own repo and then add @mesozoic-drones to the valhalla organization if that is something she would be interested in (for higher visibility maybe)?

but yeah in your own user organization as its own un-forked repo is great as well if that is more comfortable!

@nilsnolde
Copy link
Member

Happy with that as well of course. What do you think @mesozoic-drones , and don't worry if you prefer having it under your own space.

@mesozoic-drones
Copy link
Contributor Author

Maybe you want to remove that fork and set up a real repository for that?

Yes, that's what I planned to do. I created a request to github team via chat bot and now "fork" relation is completely removed.

another option i would offer would be to even move the project into the valhalla organization

Hello Kevin! Thanks for the suggestion!) For now I think it is better to leave this repo as it is.

In the near future, when I have free time, I will implement the idea of @nilsnolde
mapsme/just_gtfs#19

@nilsnolde
Copy link
Member

I created a request to github team via chat bot and now "fork" relation is completely removed.

Great! Didn't know that was a thing:)

Issues are disabled by default, just as a reminder:)

@mesozoic-drones
Copy link
Contributor Author

Thanks, I enabled issues & discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants