Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a parameter --soundon? #1

Open
paule96 opened this issue Aug 29, 2018 · 7 comments
Open

Can we get a parameter --soundon? #1

paule96 opened this issue Aug 29, 2018 · 7 comments

Comments

@paule96
Copy link

paule96 commented Aug 29, 2018

It would be create if we have a --soundon Parameter to Play the Sound file to the nyancat like:

https://www.youtube.com/watch?v=QH2-TGUlwu4

Have fun :) 🐱

@abeckDev
Copy link

Nice idea but the name sounds kind of confusing. In my opinion --withsound sounds a bit more useful.

@vandycknick
Copy link
Owner

Thanks for your suggestion, should be interesting to implement. 😄 .

Not sure about the parameter name though. Might go with --with-sound or maybe just --sound. Not really sure yet 🤔 .

@paule96
Copy link
Author

paule96 commented Aug 30, 2018

I think --sound sounds good. But how we implement this? 😄
I don't know if there a multiplattform implementation of beep out there for dotnet core 😄

@paule96
Copy link
Author

paule96 commented Aug 30, 2018

@paule96
Copy link
Author

paule96 commented Aug 30, 2018

Anybody know the melody of Nyanyanyanyanyanyanyan?

@paule96
Copy link
Author

paule96 commented Sep 1, 2018

Fuuuu…. The System.Beep funtion only supports windows :(

@vandycknick
Copy link
Owner

I added an initial rough implementation for a --sound parameter in this commit 89f17eb . It's windows only at the moment. I haven't found a native api on linux and mac yet (to be fair I also haven't looked). But I don't want to bring in some large dependency just to play some sound. So if I can't find a fairly sensible linux and mac api I'm going to leave this as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants