From 23d62d28a319cd01d0de35a85e19baaf9779c32e Mon Sep 17 00:00:00 2001 From: Dridi Boukelmoune Date: Tue, 7 Nov 2023 09:21:24 +0100 Subject: [PATCH] param: Deprecate default for bits parameters We have had the ability to reset any parameter to its default value for a while now. --- bin/varnishd/mgt/mgt_param_tweak.c | 1 + include/tbl/params.h | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bin/varnishd/mgt/mgt_param_tweak.c b/bin/varnishd/mgt/mgt_param_tweak.c index 6ec97c01add..07ad6ce303a 100644 --- a/bin/varnishd/mgt/mgt_param_tweak.c +++ b/bin/varnishd/mgt/mgt_param_tweak.c @@ -678,6 +678,7 @@ tweak_generic_bits(struct vsb *vsb, const struct parspec *par, const char *arg, unsigned j; if (arg != NULL && !strcmp(arg, "default")) { + /* XXX: deprecated in favor of param.reset */ return (tweak_generic_bits(vsb, par, par->def, p, l, tags, desc, sign)); } diff --git a/include/tbl/params.h b/include/tbl/params.h index 36923172af4..c88809da709 100644 --- a/include/tbl/params.h +++ b/include/tbl/params.h @@ -1834,7 +1834,7 @@ PARAM_BITS( "+vcl_req_reset", /* descr */ "Enable/Disable various minor features.\n" - "\tdefault\tSet default value\n" + "\tdefault\tSet default value (deprecated: use param.reset)\n" "\tnone\tDisable all features.\n\n" "Use +/- prefix to enable/disable individual feature:") #ifdef PARAM_ALL @@ -1853,7 +1853,7 @@ PARAM_BITS( "+unsafe_path", /* descr */ "Enable/Disable various VCC behaviors.\n" - "\tdefault\tSet default value\n" + "\tdefault\tSet default value (deprecated: use param.reset)\n" "\tnone\tDisable all behaviors.\n\n" "Use +/- prefix to enable/disable individual behavior:") #ifdef PARAM_ALL @@ -1885,7 +1885,7 @@ PARAM_BITS( /* descr */ "Mask individual VSL messages from being logged.\n" "\tall\tEnable all tags\n" - "\tdefault\tSet default value\n" + "\tdefault\tSet default value (deprecated: use param.reset)\n" "\nUse +/- prefix in front of VSL tag name to unmask/mask " "individual VSL messages.") PARAM_POST