Skip to content

Commit 8cf3547

Browse files
committed
Mark debug flags which should be implemented differently
I somehow missed the additional SLOW_BEREQ getting in (could be that this was during my vacation). I think we should avoid adding behavioural changes by special cased debug flags whenever we have better options, and in this case the better option are filters. Which, in this case, would come with #4035, a PR which ironically now needs additional attention just because of these changes.
1 parent bf37851 commit 8cf3547

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/tbl/debug_bits.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ DEBUG_BIT(HASHEDGE, hashedge, "Edge cases in Hash")
4141
DEBUG_BIT(VCLREL, vclrel, "Rapid VCL release")
4242
DEBUG_BIT(LURKER, lurker, "VSL Ban lurker")
4343
DEBUG_BIT(ESI_CHOP, esi_chop, "Chop ESI fetch to bits")
44-
DEBUG_BIT(FLUSH_HEAD, flush_head, "Flush after http1 head")
44+
DEBUG_BIT(FLUSH_HEAD, flush_head, "Flush after http1 head") // XXX -> filter
4545
DEBUG_BIT(VTC_MODE, vtc_mode, "Varnishtest Mode")
4646
DEBUG_BIT(WITNESS, witness, "Emit WITNESS lock records")
4747
DEBUG_BIT(VSM_KEEP, vsm_keep, "Keep the VSM file on restart")
@@ -52,7 +52,7 @@ DEBUG_BIT(PROCESSORS, processors, "Fetch/Deliver processors")
5252
DEBUG_BIT(PROTOCOL, protocol, "Protocol debugging")
5353
DEBUG_BIT(VCL_KEEP, vcl_keep, "Keep VCL C and so files")
5454
DEBUG_BIT(LCK, lck, "Additional lock statistics")
55-
DEBUG_BIT(SLOW_BEREQ, slow_bereq, "Slow down bereq")
55+
DEBUG_BIT(SLOW_BEREQ, slow_bereq, "Slow down bereq") // XXX -> filter
5656
#undef DEBUG_BIT
5757

5858
/*lint -restore */

0 commit comments

Comments
 (0)