Size pool name buffer for the worst case

nigoroll · nigoroll · commit d43e225d7216 · 2024-07-29T18:40:42.000+02:00
"999 pools ought to be enough for everyone" yet the actual maximum is UINT_MAX. Noticed while staring at #4138
diff --git a/bin/varnishd/cache/cache_session.c b/bin/varnishd/cache/cache_session.c
@@ -702,7 +702,7 @@ SES_Rel(struct sess *sp)
 void
 SES_NewPool(struct pool *pp, unsigned pool_no)
 {
-	char nb[8];
+	char nb[4 /* "sess" */ + 10 /* "%u" */ + 1];
 
 	CHECK_OBJ_NOTNULL(pp, POOL_MAGIC);
 	bprintf(nb, "req%u", pool_no);

Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,7 @@ SES_Rel(struct sess *sp)`
`702`	`702`	`void`
`703`	`703`	`SES_NewPool(struct pool *pp, unsigned pool_no)`
`704`	`704`	`{`
`705`		`- char nb[8];`
	`705`	`+ char nb[4 /* "sess" / + 10 / "%u" */ + 1];`
`706`	`706`
`707`	`707`	`CHECK_OBJ_NOTNULL(pp, POOL_MAGIC);`
`708`	`708`	`bprintf(nb, "req%u", pool_no);`