Skip to content

Commit 82e4ae0

Browse files
author
ks0m1c_dharma
committed
Relax constraint on session sync to automated id
1 parent 08effb6 commit 82e4ae0

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/vyasa_web/components/source_content/reading_content.ex

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,11 +474,15 @@ defmodule VyasaWeb.Content.ReadingContent do
474474

475475
# Helper function that syncs and mutates draft table
476476
defp mutate_draft_table(%{assigns: %{draft_table: %Vyasa.Sangh.Comment{} = dt, marks: marks}} = socket) do
477-
IO.inspect(dt, label: "DROFT")
478477
{:ok, com} = Vyasa.Sangh.update_comment(dt, %{marks: marks})
479478
socket
480479
|> assign(:draft_table, com)
481480
end
481+
482+
# when session hasnt been initialised
483+
defp mutate_draft_table(socket) do
484+
socket
485+
end
482486
# currently naive hd lookup can be filter based on active toggle,
483487
# tree like comments can be used to store nested collapsible topics (personal mark collection e.g.)
484488
# currently marks merged in and swapped out probably can be singular data structure

lib/vyasa_web/live/display_manager/display_live.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ defmodule VyasaWeb.DisplayManager.DisplayLive do
3838
}
3939
end
4040

41-
defp sync_session(%{assigns: %{session: %Session{name: name, sangh: %{id: _sangh_id}} = sess}} = socket) when is_binary(name) do
41+
defp sync_session(%{assigns: %{session: %Session{id: id, sangh: %{id: _sangh_id}} = sess}} = socket) when is_binary(id) do
4242
# currently needs name prerequisite to save
4343
socket
4444
|> push_event("initSession", sess)
4545
end
4646

47-
defp sync_session(%{assigns: %{session: %Session{name: name} = sess}} = socket) when is_binary(name) do
47+
defp sync_session(%{assigns: %{session: %Session{id: id} = sess}} = socket) when is_binary(id) do
4848
# initialises sangh if uninitiated (didnt init at Vyasa.Session)
4949
{:ok, sangh} = Sangh.create_session()
5050
sangh_sess = %{sess | sangh: sangh}

0 commit comments

Comments
 (0)