Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and Skin! #77

Open
MateusBlackyOFC opened this issue Jul 29, 2023 · 3 comments
Open

Name and Skin! #77

MateusBlackyOFC opened this issue Jul 29, 2023 · 3 comments

Comments

@MateusBlackyOFC
Copy link

Slappers name and skin are not saved when changing using /slapper edit, after restarting the server the names and skins return to their original name and skin!

@ariyacooool
Copy link

how do you make the slapper not float when I change the size?

1 similar comment
@ariyacooool
Copy link

how do you make the slapper not float when I change the size?

@Aboshxm2
Copy link

Aboshxm2 commented Jan 24, 2024

Slappers name and skin are not saved when changing using /slapper edit, after restarting the server the names and skins return to their original name and skin!

@Vecnavium it looks like the this is caused by this nbt merge where the $nbt attributes is overwritten by $this->namedTagHack.

tbh idk what's the point of namedTagHack but anyway you could fix it by switching the $nbt with $this->namedTagHack like this:

- $nbt = $nbt->merge($this->namedTagHack);
+ $nbt = $this->namedTagHack->merge($nbt);

I could open a pr if you adopted this solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants