New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments about 538 themes #6

Open

kanitw opened this issue May 29, 2018 · 0 comments

Member

kanitw commented May 29, 2018

I’m curious why the scatter and line do not have y-grid ?
I think they normally use filled points (not unfilled points like we do)
I think the theme still looks like using solid black for title and labels. I think 538 uses (very) dark grey for both. (Labels are a bit lighter)

Casyfill added a commit to Casyfill/vega-themes that referenced this issue


          tweaks to 538 Theme, addressing vega#6

8b4a51e

This was referenced Oct 8, 2018

Merge pull request #1 from vega/master #11

Closed

Five thirty eight v 1.1 #12

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment