Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments for ggplot2 #7

Open
kanitw opened this issue May 29, 2018 · 5 comments
Open

Comments for ggplot2 #7

kanitw opened this issue May 29, 2018 · 5 comments

Comments

@kanitw
Copy link
Member

kanitw commented May 29, 2018

  1. Why is the color palette back and white for colored plots

  2. I think our tick counts are way higher than ggplot normally does.

@g3o2
Copy link

g3o2 commented Jun 3, 2018

ad 2) ggplot distinguishes between minor and major gridlines. So tick count may be lower while the gridline count may be similar.

@e10v
Copy link

e10v commented Mar 22, 2023

Agree with 1. I would keep the default colors.
Also I would consider changing background for bar charts. It can be achieved by adding view: {fill: '#e5e5e5'} to config.

@domoritz
Copy link
Member

I don't have time to make these changes but would be happy to review a pull request.

@JRodez
Copy link

JRodez commented Mar 13, 2024

Is it normal that only categorical data has a custom palette ?
I can't reproduce the rendering of https://vega.github.io/vega-themes/?theme=ggplot2 using altair

@domoritz
Copy link
Member

I don't understand your question. Continues scales can also have a custom scheme.

Altair just generated Vega-Lite so there could be an issue with the particular renderer you use that doesn't load the theme. This is likely not an issue with the repo here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants