Merge pull request #11284 from vegaprotocol/pow-fix

fix: do not account for started block in the past block range

Author: jeremyletang

core/pow/engine.go

@@ -250,7 +250,7 @@ func (e *Engine) updatePowState(txs []abci.Tx) {
 	}
 
 	for i, p := range e.activeParams {
-		outOfScopeBlock := int64(e.currentBlock) + 1 - int64(p.spamPoWNumberOfPastBlocks)
+		outOfScopeBlock := int64(e.currentBlock) - int64(p.spamPoWNumberOfPastBlocks)
 		if outOfScopeBlock < 0 {
 			continue
 		}

core/pow/engine_test.go

@@ -232,7 +232,7 @@ func TestDeliverTxDuplciateNonce(t *testing.T) {
 	require.Equal(t, 2, len(e.heightToNonceRef[100]))
 
 	// check the maps are purged when we leave scope
-	e.BeginBlock(104, crypto.RandomHash(), []abci.Tx{})
+	e.BeginBlock(105, crypto.RandomHash(), []abci.Tx{})
 	require.Equal(t, 0, len(e.seenTid))
 	require.Equal(t, 0, len(e.heightToTid))
 	require.Equal(t, 0, len(e.heightToNonceRef))