Skip to content

Commit 4d615b3

Browse files
authored
Merge pull request #9729 from vegaprotocol/fix/propagate-all-netparams-on-upgrade
fix: send events for all network parameters on upgrade
2 parents 42c9248 + e6fef56 commit 4d615b3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

core/netparams/netparams.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,14 @@ func (s *Store) OnTick(ctx context.Context, _ time.Time) {
236236
// This is useful only when a protocol upgrade
237237
// is running. we will dispatch all new parameter
238238
// on the first time update here.
239+
// we propagate all parameters update to paliate
240+
// for previous release where parameters didn't
241+
// get propagated.
239242
if len(s.protocolUpgradeNewParameters) > 0 {
240-
sort.Strings(s.protocolUpgradeNewParameters)
243+
keys := maps.Keys(s.store)
244+
sort.Strings(keys)
241245

242-
for _, k := range s.protocolUpgradeNewParameters {
246+
for _, k := range keys {
243247
s.broker.Send(events.NewNetworkParameterEvent(ctx, k, s.store[k].String()))
244248
}
245249

0 commit comments

Comments
 (0)