From 6dfc7ee0c9398a19691bde91e61560a63c896634 Mon Sep 17 00:00:00 2001 From: Elias Van Ootegem Date: Wed, 1 May 2024 17:01:34 +0100 Subject: [PATCH] fix: reverse order of batch proposals Signed-off-by: Elias Van Ootegem --- CHANGELOG.md | 2 ++ datanode/entities/proposal.go | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 860702146a3..837354aac14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -82,6 +82,8 @@ - [11193](https://github.com/vegaprotocol/vega/issues/11193) - Fix loading of liquidation strategy from proto with missing data. - [11200](https://github.com/vegaprotocol/vega/issues/11200) - Make sure a party can afford the trades before they are submitted to the book. - [11205](https://github.com/vegaprotocol/vega/issues/11205) - Evaluate transfer interval correctly. +- [11005](https://github.com/vegaprotocol/vega/issues/11005) - Fix order of batch proposals to allow front-end to determine correct market ID. + ## 0.75.0 ### 🚨 Breaking changes diff --git a/datanode/entities/proposal.go b/datanode/entities/proposal.go index a939b39f666..0a7bd15574b 100644 --- a/datanode/entities/proposal.go +++ b/datanode/entities/proposal.go @@ -173,10 +173,13 @@ func (p Proposal) Cursor() *Cursor { } func (p Proposal) ToProtoEdge(_ ...any) (*v2.GovernanceDataEdge, error) { - proposalsProto := make([]*vega.Proposal, len(p.Proposals)) + j := len(p.Proposals) - 1 + proposalsProto := make([]*vega.Proposal, j+1) for i, proposal := range p.Proposals { - proposalsProto[i] = proposal.ToProto() + // fill slice in reverse order. The records are inserted (and returned) in reverse order, so to match + // the order in which markets were created, the proposals should be returned in the original order. + proposalsProto[j-i] = proposal.ToProto() } return &v2.GovernanceDataEdge{