You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When proposing an ERC20 asset and accidently setting the EVM chain-id to be one that does not correspond to any of Vega's bridge, non-validator nodes fall out of consensus. This is because the code that validates an asset against bridge chain-ids is a validator-only code path and so the asset proposal does not fail on non-validator nodes:
if s.isValidator {
client, err := s.ethClientByChainID(assetDetails.GetERC20().ChainID)
if err != nil {
return nil, err
}
a, err := erc20.New(assetID, assetDetails, s.ethWallet, client)
if err != nil {
return nil, err
}
asset = a
} else {
a, err := erc20.New(assetID, assetDetails, nil, nil)
if err != nil {
return nil, err
}
asset = a
}
Observed behaviour
Non-validator nodes fall out of consensus
Expected behaviour
Non-validator nodes remain in consensus
Steps to reproduce
Checkout branch `0027-ASSP-032`
Run `test_propose_new_erc20_bogus_chain_id`
Software version
develop
Failing test
No response
Jenkins run
No response
Configuration used
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered:
Problem encountered
When proposing an ERC20 asset and accidently setting the EVM chain-id to be one that does not correspond to any of Vega's bridge, non-validator nodes fall out of consensus. This is because the code that validates an asset against bridge chain-ids is a validator-only code path and so the asset proposal does not fail on non-validator nodes:
Observed behaviour
Non-validator nodes fall out of consensus
Expected behaviour
Non-validator nodes remain in consensus
Steps to reproduce
Software version
develop
Failing test
No response
Jenkins run
No response
Configuration used
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: