[Bug]: Spot markets cannot be enabled

[daniel1302]

Problem encountered

I have the following vega wallet:

(bots-py3.11) ➜  2024-03-20-networks-changes vega version
Vega CLI v0.76.0-preview.1 (cb4b01e745e6a26440861f1c601b1cfe20c78b0a-modified)

I have also tried with latest develop:

Vega CLI v0.76.0-dev (ec9677712478ed44643997621ece8a4f43ec72d6-modified)

I have the following proposal:

{
    "proposalSubmission": {
        "rationale": {
            "title": "Enable spot markets",
            "description": "As per title"
        },
        "terms": {
            "updateNetworkParameter": {
                "changes": {
                    "key": "spot.market.trading.enabled",
                    "value": "1"
                }
            },
            "closingTimestamp": 1710964752,
            "enactmentTimestamp": 1710964752
        }
    }
}

I execute the following command:

 2024-03-20-networks-changes vega wallet transaction send \
    --network stagnet1 \
    --passphrase-file ~/passphrase.txt \
    --wallet proposer \
    --pubkey 69464e35bcb8e8a2900ca0f87acaf252d50cf2ab2fc73694845a16b7c8a0dc6f \
    "$(cat 0-enable-spot-markets.json)"
2024-03-20T21:57:57.610+0100    INFO    round-robin-selector    node/round_robin_selector.go:147        start evaluating nodes health based on each others state
2024-03-20T21:57:57.730+0100    INFO    round-robin-selector    node/round_robin_selector.go:298        The node is responding and staged for the health check  {"host": "api.stagnet1.vega.rocks:3007"}
2024-03-20T21:57:58.121+0100    INFO    round-robin-selector    node/round_robin_selector.go:298        The node is responding and staged for the health check  {"host": "api.n05.stagnet1.vega.rocks:3007"}
2024-03-20T21:57:58.176+0100    INFO    round-robin-selector    node/round_robin_selector.go:298        The node is responding and staged for the health check  {"host": "api.n06.stagnet1.vega.rocks:3007"}
2024-03-20T21:57:58.176+0100    INFO    round-robin-selector    node/round_robin_selector.go:179        healthy nodes found     {"node-indexes": [1, 2]}
2024-03-20T21:57:58.176+0100    INFO    round-robin-selector    node/round_robin_selector.go:138        a node has been selected        {"host": "api.n05.stagnet1.vega.rocks:3007", "index": 1}

And I am getting the following error:

✗ Error: the network could not process the transaction: unknown key (ABCI code 70)

Observed behaviour

Proposal is rejected

Expected behaviour

Param is updated

Steps to reproduce

See above

Software version

v0.76.0-preview.1

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

[ze97286]

maybe because it's not the right network parameter. the right one is limits.markets.proposeSpotEnabled

[daniel1302]

Hmm I was checking the params on the data-node API and I saw this one: spot.market.trading.enabled

There was no other param related to spot markets

API: https://api.n00.stagnet1.vega.xyz/api/v2/network/parameters

[ze97286]

that's alright, just change "limits.markets.proposeSpotEnabled" and you'll see miracles.

[daniel1302]

All is good. I think we can close this issue now :) Thank you so much