Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API]: Enhance referral program & volume discount program APIs to include new fee changes #11531

Closed
5 tasks
JonRay15 opened this issue Aug 6, 2024 · 0 comments · Fixed by #11589
Closed
5 tasks

[API]: Enhance referral program & volume discount program APIs to include new fee changes #11531

JonRay15 opened this issue Aug 6, 2024 · 0 comments · Fixed by #11589
Assignees
@ze97286
Labels
api fe-request A list of reasonably high value API change requests from front end
Milestone
🏯 Suzuka Castle

Comments

@JonRay15
Copy link

JonRay15 commented Aug 6, 2024

API Overview

New fee model includes more detailed breakdown of the discounts and reward factors which need to be added to the existing APIs.

Specs

https://github.com/vegaprotocol/specs/pull/2293/files

API request details

  • Enhance referral-programs/current to include
    • Breakdown into infra / maker / liquidity referral discount factors
    • Breakdown into infra / maker / liquidity referral reward factors
  • Enhance volume-discount-programs/current to include
    • Breakdown into infra / maker / liquidity volume discount factors

Sample API output (optional)
@JonRay15 JonRay15 added api fe-request A list of reasonably high value API change requests from front end labels Aug 6, 2024
@JonRay15 JonRay15 mentioned this issue Aug 6, 2024
Open
27 tasks
@jeremyletang jeremyletang moved this to Todo in Core Kanban Aug 6, 2024
@JonRay15 JonRay15 added this to the 🏯 Suzuka Castle milestone Aug 14, 2024
@ze97286 ze97286 self-assigned this Aug 15, 2024
@EVODelavega EVODelavega mentioned this issue Aug 15, 2024
Merged
@vega-issues vega-issues moved this from Todo to Waiting Review in Core Kanban Aug 15, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Aug 15, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Aug 15, 2024
@descartes1596 descartes1596 mentioned this issue Nov 5, 2024
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ze97286 ze97286

Labels
api fe-request A list of reasonably high value API change requests from front end
Projects
Core Kanban
Archived in project
Milestone
🏯 Suzuka Castle
Development

Successfully merging a pull request may close this issue.

test: update test to include changes to protos vegaprotocol/vega
2 participants
@ze97286 @JonRay15