Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API]: Create party fees & discounts by market API #11577

Closed
13 tasks
JonRay15 opened this issue Aug 14, 2024 · 0 comments · Fixed by #11601
Closed
13 tasks

[API]: Create party fees & discounts by market API #11577

JonRay15 opened this issue Aug 14, 2024 · 0 comments · Fixed by #11601
Assignees
Labels
api fe-request A list of reasonably high value API change requests from front end

Comments

@JonRay15
Copy link

JonRay15 commented Aug 14, 2024

API Overview

In order to ... give users a clear view on their fees and discounts across all markets
We will build an API to... provide that
So that ... they can

Specs

Spec name to spec or section within a spec

Inputs

  • Party ID
  • Market ID list (optional ... if none provided show all active markets)

Outputs

  • The volume discount tier
  • The referral discount tier
  • The maker rebate boost thing tier
  • For each market
    • Undiscounted taker fee percent
    • Discounted taker fee percent
    • The base maker rebate
    • The user's final maker rebate

NB: We must be able to easily read between the tiers on this API and the tiers on the reference tiers APIs. Therefore suggest in addition to adding the tier number here we also:

  • Add tier number to volume discount program API
  • Add tier number to referral discount program API
  • Add tier number to maker rebate program API

Questions

Open questions about the feature implementation, what can be done with the APIs, or currently unresolved questions around the feature.

API test scenarios

Detailed scenarios that can be executed as feature tests to verify that the API has been implemented as expected.

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

@JonRay15 JonRay15 added the api label Aug 14, 2024
@JonRay15 JonRay15 added the fe-request A list of reasonably high value API change requests from front end label Aug 14, 2024
@JonRay15 JonRay15 added this to the 🏯 Suzuka Castle milestone Aug 14, 2024
@JonRay15 JonRay15 moved this to Todo in Core Kanban Aug 14, 2024
@vega-issues vega-issues moved this from Todo to In Progress in Core Kanban Aug 19, 2024
@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban Aug 21, 2024
@vega-issues vega-issues moved this from Waiting Review to In Review in Core Kanban Aug 21, 2024
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Aug 22, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fe-request A list of reasonably high value API change requests from front end
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants