Skip to content

Commit 85be874

Browse files
committed
FIX: Add VERAPDF_INSTALLER_FOLDER argument and fix typos
1 parent f7fbf7e commit 85be874

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
# First build the app on a maven open jdk 11 container
33
ARG VERAPDF_VERSION=1.26
44
ARG VERAPDF_MINOR_VERSION=2
5+
ARG VERAPDF_INSTALLER_FOLDER=releases
56
FROM eclipse-temurin:11-jdk-alpine AS app-installer
6-
ARG VERAPDF_VERSION
7-
ARG VERAPDF_MINOR_VERSION
87
ENV VERAPDF_VERSION=${VERAPDF_VERSION}
98
ENV VERAPDF_MINOR_VERSION=${VERAPDF_MINOR_VERSION}
9+
ENV VERAPDF_INSTALLER_FOLDER=${VERAPDF_INSTALLER_FOLDER}
1010

1111
WORKDIR /tmp
1212
COPY docker-install.xml .
13-
RUN wget -O /tmp/verapdf-installer.zip https://software.verapdf.org/releases/${VERAPDF_VERSION}/verapdf-greenfield-${VERAPDF_VERSION}.${VERAPDF_MINOR_VERSION}-installer.zip
13+
RUN wget -O /tmp/verapdf-installer.zip https://software.verapdf.org/${VERAPDF_INSTALLER_FOLDER}/${VERAPDF_VERSION}/verapdf-greenfield-${VERAPDF_VERSION}.${VERAPDF_MINOR_VERSION}-installer.zip
1414
RUN unzip verapdf-installer.zip && java -jar ./verapdf-greenfield-${VERAPDF_VERSION}.${VERAPDF_MINOR_VERSION}/verapdf-izpack-installer-${VERAPDF_VERSION}.${VERAPDF_MINOR_VERSION}.jar docker-install.xml
1515

1616
# Now build a Java JRE for the Alpine application image

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,17 @@ Where `${project.version}` is the current Maven project version. This should bri
119119

120120
## Building the Docker image
121121

122-
The accompanying [`Dockerfile`](Dockerfile) can be used to build a Docker image containing the veraPDF CLI and GUI applications. The image is based on the official Alpine image. It effedoesn't build the project, instead it downloads a version of the installer. It also builds a slimline JRE which is used to trim the final image size.
122+
The accompanying [`Dockerfile`](Dockerfile) can be used to build a Docker image containing the veraPDF CLI and GUI applications. The image is based on the official Alpine image. It doesn't build the project, instead it downloads a version of the installer. It also builds a slimline JRE which is used to trim the final image size.
123123

124-
The version built is controlled by two arguments in the Dockerfile, `VERAPDF_VERSION` and `VERAPDF_MINOR_VERSION`. These can be used to select a specific installer at invocation time. The default values are `VERAPDF_VERSION=1.27` and `VERAPDF_MINOR_VERSION=2`, which builds the latest production version, e.g. `1.26.2`.
124+
The version built is controlled by three arguments in the Dockerfile, `VERAPDF_VERSION`, `VERAPDF_MINOR_VERSION` and `VERAPDF_INSTALLER_FOLDER`. These can be used to select a specific installer at invocation time. The default values are `VERAPDF_VERSION=1.26`, `VERAPDF_MINOR_VERSION=2` and `VERAPDF_INSTALLER_FOLDER=releases`, which builds the latest production version, e.g. `1.26.2`.
125125

126126
To build and run the very latest version:
127127

128128
docker build -t verapdf .
129129
docker run -it -v "$(pwd)":/data --name verapdf verapdf a.pdf
130130

131-
To build a specific version, e.g. `1.26.3`:
131+
To build a specific version, e.g. `1.22.3`:
132132

133133
docker build --build-arg VERAPDF_VERSION=1.22 --build-arg VERAPDF_MINOR_VERSION=3 -t verapdf .
134+
135+
To build a specific development version argument `VERAPDF_INSTALLER_FOLDER` should be set to `develop`.

0 commit comments

Comments
 (0)