[turborepo] turbo gen. Add support for Github enterprise templates

[NickHackford]

What version of Turborepo are you using?

1.10.7

What package manager are you using / does the bug impact?

Yarn v2/v3 (node_modules linker only)

What operating system are you using?

Mac

Describe the Bug

When running the command yarn turbo gen workspace --copy and a url pointing to our enterprise github, I get the error.

>>> Invalid URL: "https://github.mycompany.com/shared/templates-monorepo.git". Only GitHub repositories are supported. Please use a GitHub URL and try again.

There is line here that filters out any urls that don't match github.com but I'm not sure if there's more that needs to be changed in order for this to work. I tried changing it locally and testing it but I was struggling to run my local version since it is invoked by the binary through npx.

Expected Behavior

I would expect to be able to run turbo gen copy against our enterprise github urls.

To Reproduce

Run the command yarn turbo gen workspace --copy in a repo with your own hosted github repo as the value for the copy flag.

Reproduction Repo

No response

[chris-olszewski]

Hi @NickHackford, could you provide an example URL of the enterprise repo you're trying to use (doesn't have to be exact)? Also, do you know if there's any authentication required to access the template?

[NickHackford]

Hey Chris. The url our github is hosted at is https://github.ourcompany.com and I cannot see the template unless I am logged into my enterprise github account.

[tknickman]

Hey @NickHackford, sorry for the delay here, we should be able to make this work, but it is slightly more involved than the line you pointed out! We have the check that you found in place because all of our utilities to actually download the files we need are specific to Github. You can check those out here: https://github.com/vercel/turbo/blob/main/packages/turbo-utils/src/examples.ts

We could consider opening that check to enforce .git suffix only, and then perform the optimized tar download if it's github, otherwise just attempt to grab the repo from the full url.

[tknickman]

@NickHackford could you verify that the following works for Github Ent? (I don't have access to an Ent instance myself, so I just want to double check).

Try and visit the following url and ensure it kicks off a download as expected: https://{GITHUB_ENT_HOST}/{user}/{repo}/archive/{branch}.tar.gz

[NickHackford]

Hey there. I was out on leave but I'm back now. Sorry for the delay.

I ran the command

yarn dlx turbo gen workspace --copy https://{GITHUB_ENT_HOST}/shared/templates-monorepo.git

with the proper host name and it fails when it gets to the part where it starts copying with the error.

>>> Invalid URL: "https://{GITHUB_ENT_HOST}/shared/templates-monorepo.git". Only GitHub repositories are supported. Please use a GitHub URL and try again.

The turbo version was 1.10.12. I'm not sure if it's failing somewhere else now if I'm doing something wrong.

[tknickman]

Hey @NickHackford thanks! No need to test with turbo itself yet, I'm just curious if we can download a Github ent repo in the same way as a public repo.

Can you try just going to:
https://{GITHUB_ENT_HOST}/{user}/{repo}/archive/{branch}.tar.gz in your browser and making sure it starts a download?

[NickHackford]

Sorry for the misunderstanding. That url does work and trigger a download of the repo.

[tknickman]

No worries at all - awesome! Thanks for confirming.

[anthonyshew]

Please do not add "+1" comments. If you'd like to express your interest, please upvote the top-level.