Temporarily disable require-final-newline when writing cache

Author: wyuenho

RelNotes/0.2.org

@@ -3,3 +3,7 @@
 
 #+LINK: PR https://www.github.com/vermiculus/magithub/pull/%s
 #+LINK: BUG https://www.github.com/vermiculus/magithub/issues/%s
+
+* Bug Fixes
+- ~magithub-cache-write-to-disk~ now will write to the disk without prompting
+  when ~require-final-newline~ is set to t.  [[PR:343]]

magithub-core.el

@@ -237,8 +237,9 @@ The cache is written to `magithub-cache-file' in
     (when magithub-cache--needs-write
       (magithub-in-data-dir
        (with-temp-buffer
-         (insert (prin1-to-string magithub-cache--cache))
-         (write-file magithub-cache-file)))
+         (let ((require-final-newline nil))
+           (insert (prin1-to-string magithub-cache--cache))
+           (write-file magithub-cache-file))))
       (setq magithub-cache--needs-write nil)
       (magithub-debug-message "wrote cache to disk: %S"
 			      (expand-file-name magithub-cache-file