Skip to content

Commit 9a9813b

Browse files
committed
[ui] use isNumber() BasicType property in UiUtil
1 parent 3144c37 commit 9a9813b

File tree

2 files changed

+13
-34
lines changed
  • vertigo-ui/src/main

2 files changed

+13
-34
lines changed

vertigo-ui/src/main/java/io/vertigo/ui/impl/springmvc/util/UiUtil.java

Lines changed: 12 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import io.vertigo.core.lang.WrappedException;
4242
import io.vertigo.core.locale.LocaleManager;
4343
import io.vertigo.core.node.Node;
44-
import io.vertigo.core.util.StringUtil;
4544
import io.vertigo.datamodel.data.definitions.DataDefinition;
4645
import io.vertigo.datamodel.data.definitions.DataField;
4746
import io.vertigo.datamodel.smarttype.SmartTypeManager;
@@ -95,7 +94,7 @@ public static String contextKey(final UiObject<?> uiObject) {
9594
* @return Name in context (use for input name)
9695
*/
9796
public static String generateComponentUID(final String component, final String object, final String field, final String row) {
98-
final String prefix = component +
97+
final var prefix = component +
9998
Long.toHexString(UUID.randomUUID().getLeastSignificantBits()) +
10099
"_";
101100
return contextGet(prefix, object, field, row, true);
@@ -240,20 +239,7 @@ public static String smartTypeAlign(final String object, final String fieldName,
240239
final var smartTypeDefinition = getDataField(object + '.' + fieldName).smartTypeDefinition();
241240
if (smartTypeDefinition.getScope().isBasicType()) {
242241
final var dataType = smartTypeDefinition.getBasicType();
243-
switch (dataType) {
244-
case Long:
245-
case Integer:
246-
case Double:
247-
case BigDecimal:
248-
return "right";
249-
case Boolean:
250-
case Instant:
251-
case LocalDate:
252-
case String:
253-
case DataStream:
254-
default:
255-
return "left";
256-
}
242+
return dataType.isNumber() ? "right" : "left";
257243
}
258244
}
259245
return "left";
@@ -391,9 +377,9 @@ public static String getCurrentLocaleForQuasar() {
391377
public static String compileVueJsTemplate(final String template) {
392378
final var requestParameter = new JsonObject();
393379
requestParameter.add("template", new JsonPrimitive(template));
394-
final JsonObject compiledTemplate = callRestWS("http://localhost:8083/", GSON.toJson(requestParameter), JsonObject.class);
380+
final var compiledTemplate = (JsonObject) callRestWS("http://localhost:8083/", GSON.toJson(requestParameter), JsonObject.class);
395381
final var render = compiledTemplate.get("render").getAsString();
396-
final List<String> staticRenderFns = StreamSupport.stream(compiledTemplate.get("staticRenderFns").getAsJsonArray().spliterator(), false)
382+
final var staticRenderFns = StreamSupport.stream(compiledTemplate.get("staticRenderFns").getAsJsonArray().spliterator(), false)
397383
.map(JsonElement::getAsString)
398384
.toList();
399385

@@ -482,25 +468,18 @@ private static DataField getDataField(final String fieldPath) {
482468
* @return the resolved field name
483469
*/
484470
public static String resolveDisplayField(final String object, final String field) {
485-
if (StringUtil.isBlank(object) || StringUtil.isBlank(field)) {
486-
return null;
487-
}
488-
471+
Assertion.check()
472+
.isNotBlank(object)
473+
.isNotBlank(field);
474+
// ---
489475
if (field.contains("_")) {
490476
return field; // we don't modify the field if it already contains a modifier
491477
}
492-
493478
final var dataField = getDataField(object + "." + field);
494-
final var basicType = dataField.smartTypeDefinition().getBasicType();
495-
496-
switch (basicType) {
497-
case BigDecimal:
498-
case Double:
499-
case Integer:
500-
case Long:
501-
return field + "_fmt";
502-
default:
503-
return field;
479+
final var smartTypeDefinition = dataField.smartTypeDefinition();
480+
if (smartTypeDefinition.getScope().isBasicType()) {
481+
return smartTypeDefinition.getBasicType().isNumber() ? field + "_fmt" : field;
504482
}
483+
return field;
505484
}
506485
}

vertigo-ui/src/main/resources/io/vertigo/ui/components/table/column.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
columnClass=${model.util.smartTypeCss(list, field, class, 'col_'+name)},
99
columnSortable=${sortable != null ? sortable : (field != null) },
1010
mySortField=${sortField?:field},
11-
myDisplayField=${model.util.resolveDisplayField(list, field)},
11+
myDisplayField=${field != null ? model.util.resolveDisplayField(list, field) : null},
1212
mySuffix=${model.util.smartTypeUnit(list, field, null)}">
1313
<th:block th:with="objectKey=${model.vContext['componentStates']['__${componentId}__'].addObjectToList('columns', {'name': columnName, 'field': mySortField, 'label': columnLabel, 'align': columnAlign, 'sortable': (modifiableTable!=null?false:columnSortable), 'classes':(class?:columnClass), 'headerClasses':(class?:columnClass) })},
1414
myDatetimeFormat=${datetimeFormat?:(field !=null ? model.util.getUiDatetimeFormat(list + '.' + field) : null)}">

0 commit comments

Comments
 (0)