Skip to content

Commit efec763

Browse files
author
ppinette
committed
[ui-dsfr] corrige le RouterLink pour prendre en charge la notion de aria-current
1 parent f412ebc commit efec763

File tree

9 files changed

+38
-18
lines changed

9 files changed

+38
-18
lines changed

vertigo-ui-dsfr/src/components/RouterLink.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
11
<!-- Ce composant nous permet de nous passer du router qui est utilisé par vue-dsfr pour remplacer ça par de simples liens <a> -->
22
<!-- Dans le cadre de notre MPA, ce router n’a pas réellement d’intêret et la dépendance n’est de toute façon pas tirée -->
33
<script setup>
4+
45
const props = defineProps(['to'])
6+
const current = props.to === '/'
7+
? window.location.pathname === props.to
8+
: window.location.pathname.startsWith(props.to);
9+
510
</script>
611

712
<template>
8-
<a :href="props.to">
13+
<a :href="props.to" :aria-current="current ? 'page' : undefined">
914
<slot></slot>
1015
</a>
1116
</template>

vertigo-ui/src/main/resources/io/vertigo/ui/components/dsfr/layout/dsfr-modal.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<dsfr-modal th:v-model:opened="|componentStates.${componentId}.opened|"
1212
th:@close="|componentStates.${componentId}.opened = false|"
1313
th::title="|componentStates.${componentId}.title|"
14-
th:close-button-title="#{layout.modal.close}"
1514
class="v-modal"
1615
th:attr="__${modal_attrs}__">
1716
<vu:content>
@@ -31,7 +30,7 @@
3130
</div>
3231
</template>
3332
<template #footer th:if="${closeLabel} != null">
34-
<vu:dsfr-button label="${closeLabel}" title="${closeLabel}" type="button" th::on-click="|() => componentStates.${componentId}.opened = false|" />
33+
<vu:dsfr-button label="${closeLabel}" title="${closeLabel}" type="button" th:@click="|() => componentStates.${componentId}.opened = false|" />
3534
</template>
3635
</vu:content>
3736
</dsfr-modal>

vertigo-ui/src/main/resources/io/vertigo/ui/static/3rdParty/dsfr/dsfr.es.js

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vertigo-ui/src/main/resources/io/vertigo/ui/static/3rdParty/dsfr/dsfr.es.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vertigo-ui/src/main/resources/io/vertigo/ui/static/3rdParty/dsfr/dsfr.umd.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vertigo-ui/src/main/resources/io/vertigo/ui/static/3rdParty/dsfr/dsfr.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vertigo-ui/src/main/resources/io/vertigo/ui/static/3rdParty/dsfr/style.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vertigo-ui/src/test/resources/testWebApp/WEB-INF/views/data/componentsDemoDsfr.html

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,21 @@
100100
hint="Taille maximale : 500 Mo. Formats supportés : jpg, png, pdf. Plusieurs fichiers possibles. Lorem ipsum dolor sit amet, consectetur adipiscing."
101101
th:url="'@{/commons/upload}'" required object="movie" field="pictures"/>
102102

103-
<vu:dsfr-modal componentId="myModal" iframeTitle="Coucou" closeLabel="Close"/>
103+
<vu:dsfr-dialog title="Comment ça va ?" componentId="dialog">
104+
<vu:slot name="actions_slot">
105+
<vu:dsfr-button label="Ok super" secondary/>
106+
<vu:dsfr-button label="Ah oui ?" primary @click="componentStates.dialog.opened = false"/>
107+
</vu:slot>
108+
<p>
109+
C’est une super modale
110+
</p>
111+
</vu:dsfr-dialog>
112+
<dsfr-button @click="componentStates.dialog.opened = true" label="Ouvre-moi" secondary type="button"></dsfr-button>
113+
114+
<vu:dsfr-modal componentId="myModal"
115+
iframeTitle="Coucou"
116+
autoHeight
117+
closeLabel="Close"/>
104118
<vu:dsfr-grid-cell class="q-gutter-md">
105119
<vu:dsfr-button-submit th:if="${!model.modeReadOnly}" label="Read" action="@{_read}"
106120
color="primary"/>

vertigo-ui/src/test/resources/testWebApp/WEB-INF/views/templates/dsfrLayout.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@
4848
<vu:dsfr-header-quick-link label="Notifications" url="'#'" icon="fr-icon-notification-3-line"/>
4949
<vu:dsfr-header-quick-link label="Aide" url="'#'" icon="fr-icon-question-line"/>
5050

51-
<vu:dsfr-header-nav-item label="Accueil" url="'#'"/>
52-
<vu:dsfr-header-nav-item label="Accueil" url="'#'"/>
51+
<vu:dsfr-header-nav-item label="Accueil" th:url="@{/componentsDemoDsfr/}"/>
52+
<vu:dsfr-header-nav-item label="Accueil" url="'/'"/>
53+
<vu:dsfr-header-nav-item label="Accueil" url="'/tarte/'"/>
5354
<vu:dsfr-header-nav-item-menu label="Menu">
5455
<vu:dsfr-header-nav-item label="Accueil" url="'#'"/>
5556
<vu:dsfr-header-nav-item label="Accueil" url="'#'"/>

0 commit comments

Comments
 (0)