Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fluid from container to shore up header component overflow. #173

Merged
merged 144 commits into from
Sep 5, 2023

Conversation

nojronatron
Copy link
Contributor

This is my first contribution out in the wild, taking at stab at fixing Form Fields are weirdly wide now.
In HeaderForm.js: Removed 'fluid=true' from HeaderForm and encapsulated the errorDiv and the code outside of the Form at line 452. This seemed to keep the form fields and errorDiv from spilling to the edge of the viewport. Corrected code formatting after my edits.
SampleData tubemap renderings still in tact (not pictured below).
Screenshots from local dev runs pre, and post:
tubemap_currentmasterbranch_localbuildserve
tubemap_shore_up_dropdowns_wWarnMsg

@adamnovak
Copy link
Member

@olivewong Do you think you might be able to review and merge this PR? Is it going to conflict especially much with the autocomplete work you are also doing in the header form?

ducku and others added 27 commits June 9, 2023 18:55
… Fixed popup rendering so popup is displayed if link is not copied upon button click.
… Fixed popup rendering so popup is displayed if link is not copied upon button click.
…Fixed popup rendering so popup with appropriate content is displayed.
… Fixed popup rendering so popup with appropriate content is displayed when link is not copied
Then it can set up the dev server websockets
This adds a line to the devcontainer global bashrc that checks if the Github
Codespaces variables are set, and if so sets Webpack to use the Codespaces prot
forward for its live reload websocket.

We should maybe use a Dockerfile-based build to drop this line in the global
bashrc instead.
Create React App doesn't provide a WDS_ env var to control
https://github.com/webpack/webpack-dev-server/blob/540c43852ea33f9cb18820e1cef05d5ddb86cc3e/lib/Server.js#L562-L569
when it makes the config at
https://github.com/facebook/create-react-app/blob/20edab4894b301f6b90dad0f90a2f82c52a7ac66/packages/react-scripts/config/webpackDevServer.config.js#L19-L22

So we have to actually put the server into HTTPS mode if we want WSS
used for the hot reload server. Luckily, Github's proxy ignores
self-signed certs. But we still need to set HOST or the proxy weirdly
doesn't work with HTTPS ports. See
https://github.com/orgs/community/discussions/28563#discussioncomment-4984423
Add devcontainer config to support Codespaces
… file object. AvailableTracks now takes an array of tracks
ducku and others added 29 commits August 15, 2023 20:06
Allow URLs to be inputted as BED files
Blue = forward, red = reverse
@adamnovak adamnovak merged commit b9dc0b7 into vgteam:master Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants