Skip to content

Commit ceb40de

Browse files
rustyrussellniftynei
authored andcommitted
lightningd: don't turn zero-length tlv fields into NULL.
Fixes: ElementsProject#4667 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent d38cfcf commit ceb40de

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+68
-69
lines changed

channeld/channeld_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

channeld/channeld_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

closingd/closingd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

closingd/closingd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/peer_status_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/peer_status_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/status_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/status_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connectd/connectd_gossipd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connectd/connectd_gossipd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connectd/connectd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connectd/connectd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/lightning-offer.7

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossip_store_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossip_store_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossipd_peerd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossipd_peerd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossipd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gossipd/gossipd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hsmd/hsmd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hsmd/hsmd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

onchaind/onchaind_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

onchaind/onchaind_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

openingd/dualopend_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

openingd/dualopend_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

openingd/openingd_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

openingd/openingd_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/test_pay.py

-1
Original file line numberDiff line numberDiff line change
@@ -3923,7 +3923,6 @@ def test_offer_needs_option(node_factory):
39233923
l1.rpc.call('fetchinvoice', {'offer': 'aaaa'})
39243924

39253925

3926-
@pytest.mark.xfail(strict=True)
39273926
def test_offer(node_factory, bitcoind):
39283927
plugin = os.path.join(os.path.dirname(__file__), 'plugins/currencyUSDAUD5000.py')
39293928
l1 = node_factory.get_node(options={'plugin': plugin, 'experimental-offers': None})

tools/gen/impl_template

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ towire_${type_obj.name}(${ptr}, ${'' if type_obj.is_assignable() or type_obj.is_
7979
% if f.type_obj.has_array_helper():
8080
## We assume array helpers only deal with things literally transcribed!!
8181
% if f.is_varlen():
82-
${fieldname} = ${f.size('*plen')} ? tal_arr(${ctx}, ${typename}, ${f.size('*plen')}) : NULL;
82+
${fieldname} = tal_arr(${ctx}, ${typename}, ${f.size('*plen')});
8383
% endif
8484
fromwire_${type_}_array(cursor, plen, ${fieldname}, ${f.size('*plen')});
8585
% else:

wire/bolt12_wiregen.c

+17-17
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire/bolt12_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire/common_wiregen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire/common_wiregen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire/onion_printgen.c

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire/onion_printgen.h

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)