Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observing core types #2

Open
jayvdb opened this issue Oct 31, 2019 · 1 comment
Open

Observing core types #2

jayvdb opened this issue Oct 31, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jayvdb
Copy link

jayvdb commented Oct 31, 2019

I would like to have observable dicts. This seems like a pattern that notifyr
might want to provide an implementation for, and docs with a recipe for observing other core types.

I noticed that observable(dict) fails because it adds update and collections use update. It would be useful to allow the method names to be configurable, or use semi-private names / dunder names, to avoid clashes with the wrapped classes API.

If the core type needs to be subclassed in order to be observed, a mixin would be helpful.

@victorcmoura
Copy link
Owner

@jayvdb it seems to be a great feature. Thanks for the heads up, I might be trying to implement it in a couple of weeks.

@victorcmoura victorcmoura added the enhancement New feature or request label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants