Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: non critical test #56

Open
UnixJunkie opened this issue Apr 13, 2020 · 3 comments
Open

feature request: non critical test #56

UnixJunkie opened this issue Apr 13, 2020 · 3 comments

Comments

@UnixJunkie
Copy link

I.e. the ability to declare a test as non critical if failing.
A warning could be generated and printed out, but the test suite should not fail just because
of such test failing.

The long story, some users ran the batteries test suite on an overloaded computer, then
complained that some of the tests fail in that situation...

@c-cube
Copy link
Collaborator

c-cube commented Apr 13, 2020

what would the test do, then? emit a warning?

I'm on the fence judging whether this is PEBKAC or a good idea.

@UnixJunkie
Copy link
Author

Yes, just log a warning.
This is not a "PEBKAC". Just a feature request.
If some other people find it useful, then it might be.
If not, then not (and dump it).

@c-cube
Copy link
Collaborator

c-cube commented Apr 14, 2020

I mean, about the person who tried to run the tests on an overloaded machine. I'd merge a PR for that but right now I have other things to do…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants