test mock setup refactoring

Author: visciang

test/bot_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.Bot do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "basic flow" do
     url_test_response = tg_url(tg_token(), "testResponse")

test/chat_bot_get_chat_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.ChatBotGetChat do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "updates" do
     url_test_response = tg_url(tg_token(), "testResponse")

test/chat_bot_info_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.ChatBotInfo do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "info message" do
     url_test_response = tg_url(tg_token(), "testResponse")

test/chat_bot_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.ChatBot do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "updates" do
     url_test_response = tg_url(tg_token(), "testResponse")

test/chat_bot_timeout_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.ChatBotTimeout do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "timeout" do
     url_test_response = tg_url(tg_token(), "testResponse")

test/poller_test.exs

@@ -11,17 +11,8 @@ defmodule Test.Telegram.Poller do
     end
   end
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup _context do
-    bots = [{TestBotBehaviour, [token: tg_token(), max_bot_concurrency: 1]}]
-    start_supervised!({Telegram.Poller, bots: bots})
-
-    :ok
-  end
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "basic flow" do
     url_get_updates = tg_url(tg_token(), "getUpdates")
@@ -127,4 +118,11 @@ defmodule Test.Telegram.Poller do
                end
              )
   end
+
+  defp setup_test_bot(_context) do
+    bots = [{TestBotBehaviour, [token: tg_token(), max_bot_concurrency: 1]}]
+    start_supervised!({Telegram.Poller, bots: bots})
+
+    :ok
+  end
 end

test/support/utils.ex

@@ -15,10 +15,11 @@ defmodule Test.Utils.Mock do
   @moduledoc false
 
   alias Test.Utils.Const
+  import ExUnit.Assertions
 
   @retry_wait_period Application.compile_env(:telegram, :get_updates_poll_timeout_s) * 1_000 + 500
 
-  def tesla_mock_global_async do
+  def setup_tesla_mock_global_async(_context) do
     Tesla.Mock.mock_global(fn %{url: url} = request ->
       test_pid = get_test_pid_from_request_url(url)
 
@@ -29,11 +30,13 @@ defmodule Test.Utils.Mock do
           response
       end
     end)
+
+    :ok
   end
 
   defmacro tesla_mock_expect_request(request_pattern, fun_process_req_resp, no_pending_requests \\ true) do
     quote do
-      assert_receive({:tesla_mock_request, mock_pid, request = unquote(request_pattern)}, unquote(@retry_wait_period))
+      assert_receive {:tesla_mock_request, mock_pid, request = unquote(request_pattern)}, unquote(@retry_wait_period)
 
       try do
         unquote(fun_process_req_resp).(request)
@@ -54,7 +57,7 @@ defmodule Test.Utils.Mock do
 
   defmacro tesla_mock_refute_request(request_pattern) do
     quote do
-      refute_receive({:tesla_mock_request, mock_pid, request = unquote(request_pattern)}, unquote(@retry_wait_period))
+      refute_receive {:tesla_mock_request, mock_pid, request = unquote(request_pattern)}, unquote(@retry_wait_period)
       :ok
     end
   end

test/webhook_test.exs

@@ -4,12 +4,8 @@ defmodule Test.Telegram.Webhook do
   alias Test.Webhook
   import Test.Utils.{Const, Mock}
 
-  setup_all do
-    Test.Utils.Mock.tesla_mock_global_async()
-    :ok
-  end
-
-  setup [:setup_test_bot]
+  setup_all {Test.Utils.Mock, :setup_tesla_mock_global_async}
+  setup :setup_test_bot
 
   test "basic flow" do
     url_test_response = tg_url(tg_token(), "testResponse")